From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: LL_DEBUG: Fix hang on i.MX53 when wrong port selected.
Date: Fri, 13 Feb 2015 15:02:40 +0100 [thread overview]
Message-ID: <20150213140240.GD6000@piout.net> (raw)
In-Reply-To: <20150213124849.22919.14204.stgit@localhost>
Hi Martin,
On 13/02/2015 at 13:48:49 +0100, Martin Fuzzey wrote :
> Attempts to access the i.MX53 UART data registers while the UART
> is not enabled cause the processor to hang.
>
> This can occur when CONFIG_LL_DEBUG is selected but
> CONFIG_DEBUG_IMX_UART_PORT does not correspond to the
> port enabled by the bootloader.
>
> So, do not attempt to send any data if the port is not enabled.
>
> Checking the enabled bit requires an extra scratch register.
> For the moment I have only added this to the imx version.
> Obviously, if this solution is acceptable, the register would have to be
> added to all the other implementations too in order to avoid breaking
> the build.
>
> Hence RFC status for the moment to see if there are any better ideas.
>
I think the current consensus is to not try to fix CONFIG_LL_DEBUG too
much as if you use it it means you know what you are doing, refer to the
following discussion:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/319187.html
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-02-13 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 12:48 [RFC PATCH] ARM: LL_DEBUG: Fix hang on i.MX53 when wrong port selected Martin Fuzzey
2015-02-13 13:31 ` Russell King - ARM Linux
2015-02-13 14:02 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150213140240.GD6000@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).