From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers
Date: Tue, 17 Feb 2015 09:09:02 +0100 [thread overview]
Message-ID: <201502170909.02767.marex@denx.de> (raw)
In-Reply-To: <235965536.675649.1424118291283.JavaMail.open-xchange@oxbaltgw06.schlund.de>
On Monday, February 16, 2015 at 09:24:51 PM, Stefan Wahren wrote:
> Hi Fabio,
>
> > Fabio Estevam <festevam@gmail.com> hat am 12. Februar 2015 um 20:08
> > geschrieben:
> >
> >
> > Hi Stefan,
> >
> > On Thu, Feb 12, 2015 at 4:59 PM, Stefan Wahren <stefan.wahren@i2se.com>
wrote:
> > > Hi Fabio,
> > >
> > >> Fabio Estevam <festevam@gmail.com> hat am 11. Februar 2015 um 22:10
> > >> geschrieben:
> > >>
> > >>
> > >> On Wed, Feb 11, 2015 at 6:31 PM, Stefan Wahren
> > >> <stefan.wahren@i2se.com>
> > >>
> > >> wrote:
> > >> >> I always get 0x5e5b5513 with or without your patch.
> > >> >
> > >> > very strange. Do you have any idea why IO1_STABLE is permanent low?
> > >>
> > >> On my case it is always 1.
> > >
> > > i expected the same behavior on my hardware.
> > >
> > > Do you use u-boot as bootloader?
> >
> > Yes, I do.
>
> i will try to test it with u-boot.
>
> > >> > Can you confirm the behavior according to your flash issue?
> > >>
> > >> In my tests IO1_STABLE stays the same.
> > >
> > > This wasn't the intension of my second question. I wanted to know about
> > > the state of the SPI NOR flash detection process.
> > >
> > > Does it sucessed if you apply the patch, but revert the changes in
> > > clk_ref_set_rate() from clk-ref.c?
> >
> > I don't have my mx28evk setup available at the moment, but when I
> > applied your patch and reverted all the changes in clk-ref.c, then the
> > SPI flash detection works.
> >
> > I haven't tested to only reverting the changes inside
> > clk_ref_set_rate(), but I can do it tomorrow.
>
> I think the reason for the problem in the flash detection is caused by the
> misaligned access on the frac register.
Misaligned ? In which way ? Can you please elaborate on this ?
next prev parent reply other threads:[~2015-02-17 8:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 19:20 [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers Stefan Wahren
2015-01-30 19:28 ` Fabio Estevam
2015-02-03 21:08 ` Mike Turquette
2015-02-10 12:52 ` Fabio Estevam
2015-02-10 13:05 ` Stefan Wahren
2015-02-10 13:09 ` Fabio Estevam
2015-02-10 13:55 ` Stefan Wahren
2015-02-10 15:06 ` Fabio Estevam
2015-02-10 21:24 ` Stefan Wahren
2015-02-10 21:54 ` Fabio Estevam
2015-02-10 22:07 ` Marek Vasut
2015-02-11 2:24 ` Mike Turquette
2015-02-11 16:58 ` Fabio Estevam
2015-02-11 20:31 ` Stefan Wahren
2015-02-11 21:10 ` Fabio Estevam
2015-02-12 18:59 ` Stefan Wahren
2015-02-12 19:08 ` Fabio Estevam
2015-02-16 20:24 ` Stefan Wahren
2015-02-17 8:09 ` Marek Vasut [this message]
2015-02-20 11:09 ` Stefan Wahren
-- strict thread matches above, loose matches on Subject: below --
2015-01-30 19:14 Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201502170909.02767.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).