From: treding@nvidia.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: drm: bridge: ps8622 and ptn3460 depend on gpiolib
Date: Thu, 19 Feb 2015 10:32:34 +0100 [thread overview]
Message-ID: <20150219093233.GF5086@ulmo.nvidia.com> (raw)
In-Reply-To: <19803561.otRxsE7o5u@wuerfel>
On Wed, Feb 18, 2015 at 05:09:25PM +0100, Arnd Bergmann wrote:
> The ptn3460 driver recently started usign the gpiod interface
> which is only available on platforms that come with GPIOLIB
> support, resulting in a compile-time error:
>
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_pre_enable':
> drivers/gpu/drm/bridge/ps8622.c:368:2: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
> gpiod_set_value(ps8622->gpio_rst, 0);
> ^
> drivers/gpu/drm/bridge/ps8622.c: In function 'ps8622_probe':
> drivers/gpu/drm/bridge/ps8622.c:584:2: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]
> ps8622->gpio_slp = devm_gpiod_get(dev, "sleep");
> ^
>
> Similarly, the newly added ps8622 driver started out with the same
> problem.
>
> This patch adds explicit Kconfig dependencies to avoid trying to
> build invalid configurations.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: f1336e6afb ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")
> Fixes: af478d8823 ("drm/bridge: ptn3460: use gpiod interface")
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150219/355be74c/attachment.sig>
prev parent reply other threads:[~2015-02-19 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 16:09 drm: bridge: ps8622 and ptn3460 depend on gpiolib Arnd Bergmann
2015-02-18 19:54 ` Javier Martinez Canillas
2015-02-19 9:32 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219093233.GF5086@ulmo.nvidia.com \
--to=treding@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).