From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Thu, 19 Feb 2015 10:36:00 -0800 Subject: [PATCH 3/4] arm: am33xx: DT quirks for am33xx based beaglebone variants In-Reply-To: <9C7BFC7C-0751-4233-927F-D01AF078704B@antoniou-consulting.com> References: <1424271576-1952-1-git-send-email-pantelis.antoniou@konsulko.com> <1424271576-1952-4-git-send-email-pantelis.antoniou@konsulko.com> <20150219181656.GF32521@atomide.com> <9C7BFC7C-0751-4233-927F-D01AF078704B@antoniou-consulting.com> Message-ID: <20150219183600.GG32521@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Pantelis Antoniou [150219 10:32]: > > On Feb 19, 2015, at 20:16 , Tony Lindgren wrote: > > > > Uhh I don't like the idea of duplicating the i2c-omap.c driver under > > arch/arm.. And in general we should initialize things later rather > > than earlier. > > > > What's stopping doing these quirk checks later on time with just > > a regular device driver, something like drivers/misc/bbone-quirks.c? > > > > We have no choice; we are way early in the boot process, right after > the device tree unflattening step. To me it seems the dt patching part should be done with minimal code before any driver like features.. > I?ve toyed with the idea of using early platform devices but the omap-i2c driver > would need some tender love and care to make it work, and I didn?t want to get > bogged down with i2c driver details at this point. ..so how about just parse a kernel cmdline for the quirks to apply based on a version string or similar? That can be easily populated by u-boot or set manually with setenv. That leaves out the need for tinkering with i2c super early in the kernel for revision detection. Regards, Tony