linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net/appletalk: LTPC needs virt_to_bus
@ 2015-02-18 19:48 Arnd Bergmann
  2015-02-20 21:28 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-02-18 19:48 UTC (permalink / raw)
  To: linux-arm-kernel

The ltpc driver is rather outdated and does not get built on most
platforms because it requires the ISA_DMA_API symbol. However
there are some ARM platforms that have ISA_DMA_API but no virt_to_bus,
and they get this build error when enabling the ltpc driver.

drivers/net/appletalk/ltpc.c: In function 'handlefc':
drivers/net/appletalk/ltpc.c:380:2: error: implicit declaration of function 'virt_to_bus' [-Werror=implicit-function-declaration]
  set_dma_addr(dma,virt_to_bus(ltdmacbuf));
  ^

This adds another dependency in Kconfig to avoid that configuration.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/drivers/net/appletalk/Kconfig b/drivers/net/appletalk/Kconfig
index 4ce6ca5f3d36..dc6b78e5342f 100644
--- a/drivers/net/appletalk/Kconfig
+++ b/drivers/net/appletalk/Kconfig
@@ -40,7 +40,7 @@ config DEV_APPLETALK
 
 config LTPC
 	tristate "Apple/Farallon LocalTalk PC support"
-	depends on DEV_APPLETALK && (ISA || EISA) && ISA_DMA_API
+	depends on DEV_APPLETALK && (ISA || EISA) && ISA_DMA_API && VIRT_TO_BUS
 	help
 	  This allows you to use the AppleTalk PC card to connect to LocalTalk
 	  networks. The card is also known as the Farallon PhoneNet PC card.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] net/appletalk: LTPC needs virt_to_bus
  2015-02-18 19:48 [PATCH] net/appletalk: LTPC needs virt_to_bus Arnd Bergmann
@ 2015-02-20 21:28 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-02-20 21:28 UTC (permalink / raw)
  To: linux-arm-kernel

From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 18 Feb 2015 20:48:54 +0100

> The ltpc driver is rather outdated and does not get built on most
> platforms because it requires the ISA_DMA_API symbol. However
> there are some ARM platforms that have ISA_DMA_API but no virt_to_bus,
> and they get this build error when enabling the ltpc driver.
> 
> drivers/net/appletalk/ltpc.c: In function 'handlefc':
> drivers/net/appletalk/ltpc.c:380:2: error: implicit declaration of function 'virt_to_bus' [-Werror=implicit-function-declaration]
>   set_dma_addr(dma,virt_to_bus(ltdmacbuf));
>   ^
> 
> This adds another dependency in Kconfig to avoid that configuration.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-20 21:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-18 19:48 [PATCH] net/appletalk: LTPC needs virt_to_bus Arnd Bergmann
2015-02-20 21:28 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).