[PATCH v3 08/13] mtd: st_spi_fsm: Update the JEDEC probe to handle extended READIDs

Lee Jones
2015-01-21T13:02:04Z

On Mon, 12 Jan 2015, Brian Norris wrote:

> On Mon, Dec 15, 2014 at 11:59:15AM +0000, Lee Jones wrote:
> > The previous code was based on 3-byte JEDEC IDs, with a possible 2-byte
> > extension. However, devices are now emerging that return 6 or more bytes of
> > READID data and the additional bytes are required to differentiate between
> > variants or generations of similar devices.
> >
> > This patch refactors the device table and JEDEC probe code to handle arbitrary
> > length READIDs, with the standard JEDEC definition now becoming a special case.
> > Functionally, there should be no change in behaviour. A subsequent patch will
> > update the table with extended READIDs where applicable.
>
> BTW, how's that promise going, where you work on adapting this driver to
> the spi-nor framework? We've already done some of this same work there.

I have pushed this point within ST and someone has agreed to do the
work. Last I heard it relied on these patches, but I'll ask again.

> > +#define RDID(...) __VA_ARGS__ /* Dummy macro to protect array argument. */
>
> What? What needs "protected"?

You're asking me questions I can't answer I'm afraid and Angus has now
left the building. I guess he thinks __VA_ARGS__ will prevent some
kind of overflow?

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog