From mboxrd@z Thu Jan 1 00:00:00 1970 From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi) Date: Wed, 25 Feb 2015 08:31:16 +0000 Subject: [PATCH] drivers: cpuidle: Explictly include proc-fns.h for cpuidle-arm64 In-Reply-To: <1424827506-12245-1-git-send-email-lauraa@codeaurora.org> References: <1424827506-12245-1-git-send-email-lauraa@codeaurora.org> Message-ID: <20150225083116.GA22410@e102568-lin.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Feb 25, 2015 at 01:25:06AM +0000, Laura Abbott wrote: > cpuidle-arm64.c fails to compile with CONFIG_ARM64_64K_PAGES=y > > /kernel/drivers/cpuidle/cpuidle-arm64.c: In function "arm64_enter_idle_state" > /kernel/drivers/cpuidle/cpuidle-arm64.c:42:3: error: implicit declaration of function "cpu_do_idle" [-Werror=implicit-function-declaration] > cpu_do_idle(); > ^ > > Explicitly add the header file with the declaration of cpu_do_idle. I was about to send the same patch. Acked-by: Lorenzo Pieralisi > > Signed-off-by: Laura Abbott > --- > Not sure how long this has been broken, bisect between v3.19 and master showed > 6b00f7efb5303418c231994c91fb8239f5ada260 as the first bad commit which > isn't particularly helpful. Probably some header shuffling. Yes, agreed, I was trying to bisect it yesterday, but including the asm/proc-fns.h file is the right thing to do regardless. Thanks, Lorenzo > --- > drivers/cpuidle/cpuidle-arm64.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpuidle/cpuidle-arm64.c b/drivers/cpuidle/cpuidle-arm64.c > index 80704b9..f1d5422 100644 > --- a/drivers/cpuidle/cpuidle-arm64.c > +++ b/drivers/cpuidle/cpuidle-arm64.c > @@ -19,6 +19,7 @@ > #include > > #include > +#include > #include > > #include "dt_idle_states.h" > -- > Qualcomm Innovation Center, Inc. > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project > >