linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers: cpuidle: Explictly include proc-fns.h for cpuidle-arm64
Date: Wed, 25 Feb 2015 11:39:55 +0000	[thread overview]
Message-ID: <20150225113955.GB9714@leverpostej> (raw)
In-Reply-To: <20150225112758.GB20214@red-moon>

Hi Lorenzo,

> Subject: [PATCH] drivers: cpuidle: cpuidle-arm64: include asm/proc-fns.h
>  explicitly
> 
> ARM64 CPUidle driver requires the cpu_do_idle function so that it can
> be used to enter the shallowest idle state, and it is declared in
> asm/proc-fns.h.
> 
> This patch adds the explicit inclusion of the asm/proc-fns.h header file
> to stop relying on implicit inclusion of the same file through implicit
> header files dependencies.

Laura's original commit message made it clear that this was a real
problem for CONFIG_ARM64_64K_PAGES=y, while this makes it sound like a
cleanup.

We should make it clear that without this the build is broken when
CONFIG_ARM64_64K_PAGES=y.

> Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
> [lp: rebased/rewrote commit log]
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

Otherwise this applies, and seems to work:

Tested-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  drivers/cpuidle/cpuidle-arm64.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpuidle/cpuidle-arm64.c b/drivers/cpuidle/cpuidle-arm64.c
> index 39a2c62..c8bb6c5 100644
> --- a/drivers/cpuidle/cpuidle-arm64.c
> +++ b/drivers/cpuidle/cpuidle-arm64.c
> @@ -19,6 +19,7 @@
>  #include <linux/of.h>
>  
>  #include <asm/cpuidle.h>
> +#include <asm/proc-fns.h>
>  
>  #include "dt_idle_states.h"
>  
> -- 
> 2.2.1
> 
> 

  reply	other threads:[~2015-02-25 11:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25  1:25 [PATCH] drivers: cpuidle: Explictly include proc-fns.h for cpuidle-arm64 Laura Abbott
2015-02-25  8:31 ` Lorenzo Pieralisi
2015-02-25 11:18 ` Mark Rutland
2015-02-25 11:27   ` Lorenzo Pieralisi
2015-02-25 11:39     ` Mark Rutland [this message]
2015-02-25 18:04     ` Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150225113955.GB9714@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).