From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/10] ARM: omap2: use clkdev_add_alias()
Date: Mon, 2 Mar 2015 16:13:42 -0800 [thread overview]
Message-ID: <20150303001341.GD3756@atomide.com> (raw)
In-Reply-To: <E1YSTnw-0001K5-IQ@rmk-PC.arm.linux.org.uk>
* Russell King <rmk+kernel@arm.linux.org.uk> [150302 09:10]:
> When creating aliases of existing clkdev clocks, use clkdev_add_alias()
> isntead of open coding the lookup and clk_lookup creation.
Gave this series a quick try but I get these build errors:
arch/arm/mach-omap2/omap_device.c: In function ?_add_clkdev?:
arch/arm/mach-omap2/omap_device.c:65:58: warning: passing argument 3 of ?clk_add_alias? discards ?const? qualifier from pointer target type
rc = clk_add_alias(clk_alias, dev_name(&od->pdev->dev), clk_name, NULL);
^
In file included from arch/arm/mach-omap2/omap_device.c:34:0:
include/linux/clkdev.h:44:5: note: expected ?char *? but argument is of type ?const char *?
int clk_add_alias(const char *, const char *, char *, struct device *);
^
drivers/clk/clkdev.c:298:16: error: expected declaration specifiers or ?...? before ?(? token
vclkdev_create((struct clk *clk, const char *con_id, const char *dev_fmt,
^
drivers/clk/clkdev.c:322:92: error: storage class specified for parameter ?__crc_clkdev_alloc?
EXPORT_SYMBOL(clkdev_alloc);
^
drivers/clk/clkdev.c:322:1: warning: ?weak? attribute ignored [-Wattributes]
EXPORT_SYMBOL(clkdev_alloc);
^
drivers/clk/clkdev.c:322:1: warning: ?externally_visible? attribute ignored [-Wattributes]
drivers/clk/clkdev.c:322:161: error: storage class specified for parameter ?__kcrctab_clkdev_alloc?
EXPORT_SYMBOL(clkdev_alloc);
^
drivers/clk/clkdev.c:322:1: warning: ?__used__? attribute ignored [-Wattributes]
EXPORT_SYMBOL(clkdev_alloc);
^
drivers/clk/clkdev.c:322:161: error: section attribute not allowed for ?__kcrctab_clkdev_alloc?
EXPORT_SYMBOL(clkdev_alloc);
^
drivers/clk/clkdev.c:322:279: error: expected ?;?, ?,? or ?)? before ?=? token
EXPORT_SYMBOL(clkdev_alloc);
drivers/clk/clkdev.c:274:1: warning: ?vclkdev_alloc? defined but not used [-Wunused-function]
vclkdev_alloc(struct clk *clk, const char *con_id, const char *dev_fmt,
Regards,
Tony
next prev parent reply other threads:[~2015-03-03 0:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 17:05 [PATCH 00/10] initial clkdev cleanups Russell King - ARM Linux
2015-03-02 17:06 ` [PATCH 01/10] media: omap3isp: remove unused clkdev Russell King
2015-03-02 22:33 ` Laurent Pinchart
2015-03-02 22:53 ` Sakari Ailus
2015-03-02 23:54 ` Russell King - ARM Linux
2015-03-03 0:39 ` Laurent Pinchart
2015-03-03 22:09 ` Sakari Ailus
2015-03-03 23:09 ` Sakari Ailus
2015-03-02 17:06 ` [PATCH 02/10] SH: use clkdev_add_table() Russell King
2015-03-02 17:18 ` Geert Uytterhoeven
2015-03-02 17:06 ` [PATCH 03/10] clk: versatile: convert Integrator IM/PD-1 to " Russell King
2015-03-02 17:06 ` [PATCH 04/10] ARM: lpc32xx: convert " Russell King
2015-03-02 17:06 ` [PATCH 05/10] clkdev: add clkdev_create() helper Russell King
2015-03-02 17:22 ` Geert Uytterhoeven
2015-03-02 17:46 ` Russell King - ARM Linux
2015-03-02 20:36 ` Geert Uytterhoeven
2015-03-02 19:07 ` Stephen Boyd
2015-03-02 21:01 ` Russell King - ARM Linux
2015-03-02 21:54 ` Stephen Boyd
2015-03-02 17:06 ` [PATCH 06/10] ASOC: migor: use clkdev_create() Russell King
2015-03-02 17:29 ` Mark Brown
2015-03-02 17:06 ` [PATCH 07/10] clk: s2mps11: " Russell King
2015-03-02 17:06 ` [PATCH 08/10] ARM: orion: " Russell King
2015-03-03 10:25 ` Thomas Petazzoni
2015-03-02 17:06 ` [PATCH 09/10] ARM: omap2: " Russell King
2015-03-02 17:06 ` [PATCH 10/10] ARM: omap2: use clkdev_add_alias() Russell King
2015-03-03 0:13 ` Tony Lindgren [this message]
2015-03-02 21:50 ` [PATCH 00/10] initial clkdev cleanups Stephen Boyd
2015-03-03 15:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303001341.GD3756@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).