linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
Date: Tue, 3 Mar 2015 09:26:20 +0100	[thread overview]
Message-ID: <20150303092620.63e1861d@bbrezillon> (raw)
In-Reply-To: <1425368567-5333-1-git-send-email-alexandre.belloni@free-electrons.com>

Hi Alexandre,

On Tue,  3 Mar 2015 08:42:47 +0100
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:

> Since the addition of the errata handling for at91sam9rl and at91sam9g45, the
> atmel_usba_udc depends on the pmc driver being present. Explicitly set that
> dependency.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>  drivers/usb/gadget/udc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> index 9a3a6b00391a..b04206fdba11 100644
> --- a/drivers/usb/gadget/udc/Kconfig
> +++ b/drivers/usb/gadget/udc/Kconfig
> @@ -55,7 +55,7 @@ config USB_LPC32XX
>  
>  config USB_ATMEL_USBA
>  	tristate "Atmel USBA"
> -	depends on AVR32 || ARCH_AT91
> +	depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91

I guess you should add parenthesis to make it clearer ?

	depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91)

And I wonder why you need that. I though this option was selected by all
at91 platforms ?

Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2015-03-03  8:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03  7:42 [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91 Alexandre Belloni
2015-03-03  8:26 ` Boris Brezillon [this message]
2015-03-03  9:41   ` Alexandre Belloni
2015-03-10 20:53     ` Felipe Balbi
2015-03-10 21:21       ` Alexandre Belloni
2015-03-10 21:23         ` Felipe Balbi
2015-03-10 21:41           ` Alexandre Belloni
2015-03-10 21:41             ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150303092620.63e1861d@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).