* [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
@ 2015-03-03 7:42 Alexandre Belloni
2015-03-03 8:26 ` Boris Brezillon
0 siblings, 1 reply; 8+ messages in thread
From: Alexandre Belloni @ 2015-03-03 7:42 UTC (permalink / raw)
To: linux-arm-kernel
Since the addition of the errata handling for at91sam9rl and at91sam9g45, the
atmel_usba_udc depends on the pmc driver being present. Explicitly set that
dependency.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
drivers/usb/gadget/udc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
index 9a3a6b00391a..b04206fdba11 100644
--- a/drivers/usb/gadget/udc/Kconfig
+++ b/drivers/usb/gadget/udc/Kconfig
@@ -55,7 +55,7 @@ config USB_LPC32XX
config USB_ATMEL_USBA
tristate "Atmel USBA"
- depends on AVR32 || ARCH_AT91
+ depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91
help
USBA is the integrated high-speed USB Device controller on
the AT32AP700x, some AT91SAM9 and AT91CAP9 processors from Atmel.
--
2.1.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
2015-03-03 7:42 [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91 Alexandre Belloni
@ 2015-03-03 8:26 ` Boris Brezillon
2015-03-03 9:41 ` Alexandre Belloni
0 siblings, 1 reply; 8+ messages in thread
From: Boris Brezillon @ 2015-03-03 8:26 UTC (permalink / raw)
To: linux-arm-kernel
Hi Alexandre,
On Tue, 3 Mar 2015 08:42:47 +0100
Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote:
> Since the addition of the errata handling for at91sam9rl and at91sam9g45, the
> atmel_usba_udc depends on the pmc driver being present. Explicitly set that
> dependency.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/usb/gadget/udc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> index 9a3a6b00391a..b04206fdba11 100644
> --- a/drivers/usb/gadget/udc/Kconfig
> +++ b/drivers/usb/gadget/udc/Kconfig
> @@ -55,7 +55,7 @@ config USB_LPC32XX
>
> config USB_ATMEL_USBA
> tristate "Atmel USBA"
> - depends on AVR32 || ARCH_AT91
> + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91
I guess you should add parenthesis to make it clearer ?
depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91)
And I wonder why you need that. I though this option was selected by all
at91 platforms ?
Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
2015-03-03 8:26 ` Boris Brezillon
@ 2015-03-03 9:41 ` Alexandre Belloni
2015-03-10 20:53 ` Felipe Balbi
0 siblings, 1 reply; 8+ messages in thread
From: Alexandre Belloni @ 2015-03-03 9:41 UTC (permalink / raw)
To: linux-arm-kernel
On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote :
> > config USB_ATMEL_USBA
> > tristate "Atmel USBA"
> > - depends on AVR32 || ARCH_AT91
> > + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91
>
> I guess you should add parenthesis to make it clearer ?
>
> depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91)
>
> And I wonder why you need that. I though this option was selected by all
> at91 platforms ?
>
That is currently the case but maybe, one day, one of the AT91 platform
will not use the same clock driver.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
2015-03-03 9:41 ` Alexandre Belloni
@ 2015-03-10 20:53 ` Felipe Balbi
2015-03-10 21:21 ` Alexandre Belloni
0 siblings, 1 reply; 8+ messages in thread
From: Felipe Balbi @ 2015-03-10 20:53 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote:
> On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote :
> > > config USB_ATMEL_USBA
> > > tristate "Atmel USBA"
> > > - depends on AVR32 || ARCH_AT91
> > > + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91
> >
> > I guess you should add parenthesis to make it clearer ?
> >
> > depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91)
> >
> > And I wonder why you need that. I though this option was selected by all
> > at91 platforms ?
> >
>
> That is currently the case but maybe, one day, one of the AT91 platform
> will not use the same clock driver.
then, maybe, one day, you send this patch.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150310/5a330a33/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
2015-03-10 20:53 ` Felipe Balbi
@ 2015-03-10 21:21 ` Alexandre Belloni
2015-03-10 21:23 ` Felipe Balbi
0 siblings, 1 reply; 8+ messages in thread
From: Alexandre Belloni @ 2015-03-10 21:21 UTC (permalink / raw)
To: linux-arm-kernel
On 10/03/2015 at 15:53:12 -0500, Felipe Balbi wrote :
> On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote:
> > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote :
> > > > config USB_ATMEL_USBA
> > > > tristate "Atmel USBA"
> > > > - depends on AVR32 || ARCH_AT91
> > > > + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91
> > >
> > > I guess you should add parenthesis to make it clearer ?
> > >
> > > depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91)
> > >
> > > And I wonder why you need that. I though this option was selected by all
> > > at91 platforms ?
> > >
> >
> > That is currently the case but maybe, one day, one of the AT91 platform
> > will not use the same clock driver.
>
> then, maybe, one day, you send this patch.
Yeah, let's drop it for now but I have the feeling that this will
break (I actually broke it when switching at91 to multiplatform).
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
2015-03-10 21:21 ` Alexandre Belloni
@ 2015-03-10 21:23 ` Felipe Balbi
2015-03-10 21:41 ` Alexandre Belloni
0 siblings, 1 reply; 8+ messages in thread
From: Felipe Balbi @ 2015-03-10 21:23 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 10, 2015 at 10:21:22PM +0100, Alexandre Belloni wrote:
> On 10/03/2015 at 15:53:12 -0500, Felipe Balbi wrote :
> > On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote:
> > > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote :
> > > > > config USB_ATMEL_USBA
> > > > > tristate "Atmel USBA"
> > > > > - depends on AVR32 || ARCH_AT91
> > > > > + depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91
> > > >
> > > > I guess you should add parenthesis to make it clearer ?
> > > >
> > > > depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91)
> > > >
> > > > And I wonder why you need that. I though this option was selected by all
> > > > at91 platforms ?
> > > >
> > >
> > > That is currently the case but maybe, one day, one of the AT91 platform
> > > will not use the same clock driver.
> >
> > then, maybe, one day, you send this patch.
>
> Yeah, let's drop it for now but I have the feeling that this will
> break (I actually broke it when switching at91 to multiplatform).
aha, that changes it. So you already have something which makes this
break ? Are you planning on sending that upstream any time soon ?
We could very well use that same series to merge this patch. Only when
it's needed ;-)
cheers
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150310/88511924/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
2015-03-10 21:23 ` Felipe Balbi
@ 2015-03-10 21:41 ` Alexandre Belloni
2015-03-10 21:41 ` Felipe Balbi
0 siblings, 1 reply; 8+ messages in thread
From: Alexandre Belloni @ 2015-03-10 21:41 UTC (permalink / raw)
To: linux-arm-kernel
On 10/03/2015 at 16:23:53 -0500, Felipe Balbi wrote :
> > Yeah, let's drop it for now but I have the feeling that this will
> > break (I actually broke it when switching at91 to multiplatform).
>
> aha, that changes it. So you already have something which makes this
> break ? Are you planning on sending that upstream any time soon ?
>
It has been sent but not merge and I need to send another version.
> We could very well use that same series to merge this patch. Only when
> it's needed ;-)
>
Like said, this is not an issue for now, I fixed it by simply having all
the AT91 platform selecting COMMON_CLK_AT91. I just have the feeling
that this is not quite future proof.
So this is not urgent at all and I'll try to remember to resend when
needed.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
2015-03-10 21:41 ` Alexandre Belloni
@ 2015-03-10 21:41 ` Felipe Balbi
0 siblings, 0 replies; 8+ messages in thread
From: Felipe Balbi @ 2015-03-10 21:41 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 10, 2015 at 10:41:09PM +0100, Alexandre Belloni wrote:
> On 10/03/2015 at 16:23:53 -0500, Felipe Balbi wrote :
> > > Yeah, let's drop it for now but I have the feeling that this will
> > > break (I actually broke it when switching at91 to multiplatform).
> >
> > aha, that changes it. So you already have something which makes this
> > break ? Are you planning on sending that upstream any time soon ?
> >
>
> It has been sent but not merge and I need to send another version.
>
> > We could very well use that same series to merge this patch. Only when
> > it's needed ;-)
> >
>
> Like said, this is not an issue for now, I fixed it by simply having all
> the AT91 platform selecting COMMON_CLK_AT91. I just have the feeling
> that this is not quite future proof.
> So this is not urgent at all and I'll try to remember to resend when
> needed.
fair enough :-)
cheers
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150310/cd2cde8a/attachment.sig>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-10 21:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-03 7:42 [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91 Alexandre Belloni
2015-03-03 8:26 ` Boris Brezillon
2015-03-03 9:41 ` Alexandre Belloni
2015-03-10 20:53 ` Felipe Balbi
2015-03-10 21:21 ` Alexandre Belloni
2015-03-10 21:23 ` Felipe Balbi
2015-03-10 21:41 ` Alexandre Belloni
2015-03-10 21:41 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).