* [PATCH] ARM: at91: pm: change at91_pm_set_standby() to static
@ 2015-03-04 1:44 Wenyou Yang
2015-03-04 7:35 ` Alexandre Belloni
2015-03-12 14:14 ` Nicolas Ferre
0 siblings, 2 replies; 3+ messages in thread
From: Wenyou Yang @ 2015-03-04 1:44 UTC (permalink / raw)
To: linux-arm-kernel
Since at91_pm_set_standby() will not be used out of the pm.c file,
change its attribute from extern to static, remove its declaration as well.
void at91_pm_set_standby(void (*at91_standby)(void))
-->
static void at91_pm_set_standby(void (*at91_standby)(void))
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---
arch/arm/mach-at91/pm.c | 2 +-
arch/arm/mach-at91/pm.h | 6 ------
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
index aa4116e..a4473dc 100644
--- a/arch/arm/mach-at91/pm.c
+++ b/arch/arm/mach-at91/pm.c
@@ -218,7 +218,7 @@ static struct platform_device at91_cpuidle_device = {
.name = "cpuidle-at91",
};
-void at91_pm_set_standby(void (*at91_standby)(void))
+static void at91_pm_set_standby(void (*at91_standby)(void))
{
if (at91_standby) {
at91_cpuidle_device.dev.platform_data = at91_standby;
diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
index 86c0aa8..86a9d0b 100644
--- a/arch/arm/mach-at91/pm.h
+++ b/arch/arm/mach-at91/pm.h
@@ -15,12 +15,6 @@
#include <mach/at91_ramc.h>
-#ifdef CONFIG_PM
-extern void at91_pm_set_standby(void (*at91_standby)(void));
-#else
-static inline void at91_pm_set_standby(void (*at91_standby)(void)) { }
-#endif
-
/*
* The AT91RM9200 goes into self-refresh mode with this command, and will
* terminate self-refresh automatically on the next SDRAM access.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: at91: pm: change at91_pm_set_standby() to static
2015-03-04 1:44 [PATCH] ARM: at91: pm: change at91_pm_set_standby() to static Wenyou Yang
@ 2015-03-04 7:35 ` Alexandre Belloni
2015-03-12 14:14 ` Nicolas Ferre
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2015-03-04 7:35 UTC (permalink / raw)
To: linux-arm-kernel
On 04/03/2015 at 09:44:45 +0800, Wenyou Yang wrote :
> Since at91_pm_set_standby() will not be used out of the pm.c file,
> change its attribute from extern to static, remove its declaration as well.
>
> void at91_pm_set_standby(void (*at91_standby)(void))
> -->
> static void at91_pm_set_standby(void (*at91_standby)(void))
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/mach-at91/pm.c | 2 +-
> arch/arm/mach-at91/pm.h | 6 ------
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index aa4116e..a4473dc 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -218,7 +218,7 @@ static struct platform_device at91_cpuidle_device = {
> .name = "cpuidle-at91",
> };
>
> -void at91_pm_set_standby(void (*at91_standby)(void))
> +static void at91_pm_set_standby(void (*at91_standby)(void))
> {
> if (at91_standby) {
> at91_cpuidle_device.dev.platform_data = at91_standby;
> diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
> index 86c0aa8..86a9d0b 100644
> --- a/arch/arm/mach-at91/pm.h
> +++ b/arch/arm/mach-at91/pm.h
> @@ -15,12 +15,6 @@
>
> #include <mach/at91_ramc.h>
>
> -#ifdef CONFIG_PM
> -extern void at91_pm_set_standby(void (*at91_standby)(void));
> -#else
> -static inline void at91_pm_set_standby(void (*at91_standby)(void)) { }
> -#endif
> -
> /*
> * The AT91RM9200 goes into self-refresh mode with this command, and will
> * terminate self-refresh automatically on the next SDRAM access.
> --
> 1.7.9.5
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: at91: pm: change at91_pm_set_standby() to static
2015-03-04 1:44 [PATCH] ARM: at91: pm: change at91_pm_set_standby() to static Wenyou Yang
2015-03-04 7:35 ` Alexandre Belloni
@ 2015-03-12 14:14 ` Nicolas Ferre
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2015-03-12 14:14 UTC (permalink / raw)
To: linux-arm-kernel
Le 04/03/2015 02:44, Wenyou Yang a ?crit :
> Since at91_pm_set_standby() will not be used out of the pm.c file,
> change its attribute from extern to static, remove its declaration as well.
>
> void at91_pm_set_standby(void (*at91_standby)(void))
> -->
> static void at91_pm_set_standby(void (*at91_standby)(void))
These 3 lines are not needed ^^^^
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Thanks, I add this to the at91-4.1-cleanup branch.
Bye,
> ---
> arch/arm/mach-at91/pm.c | 2 +-
> arch/arm/mach-at91/pm.h | 6 ------
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index aa4116e..a4473dc 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -218,7 +218,7 @@ static struct platform_device at91_cpuidle_device = {
> .name = "cpuidle-at91",
> };
>
> -void at91_pm_set_standby(void (*at91_standby)(void))
> +static void at91_pm_set_standby(void (*at91_standby)(void))
> {
> if (at91_standby) {
> at91_cpuidle_device.dev.platform_data = at91_standby;
> diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
> index 86c0aa8..86a9d0b 100644
> --- a/arch/arm/mach-at91/pm.h
> +++ b/arch/arm/mach-at91/pm.h
> @@ -15,12 +15,6 @@
>
> #include <mach/at91_ramc.h>
>
> -#ifdef CONFIG_PM
> -extern void at91_pm_set_standby(void (*at91_standby)(void));
> -#else
> -static inline void at91_pm_set_standby(void (*at91_standby)(void)) { }
> -#endif
> -
> /*
> * The AT91RM9200 goes into self-refresh mode with this command, and will
> * terminate self-refresh automatically on the next SDRAM access.
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-12 14:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-04 1:44 [PATCH] ARM: at91: pm: change at91_pm_set_standby() to static Wenyou Yang
2015-03-04 7:35 ` Alexandre Belloni
2015-03-12 14:14 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).