* [PATCH] ARM: at91/dt: keep watchdog running in idle mode
@ 2014-12-23 11:41 Michel Marti
2015-03-04 10:04 ` Boris Brezillon
2015-03-04 10:18 ` Sylvain Rochet
0 siblings, 2 replies; 4+ messages in thread
From: Michel Marti @ 2014-12-23 11:41 UTC (permalink / raw)
To: linux-arm-kernel
Since turning on idle-halt in commit fe46aa679, SoCs compatible with
the sam9 watchdog no longer reboot if the wdt times out. Removing the
'idle-halt' flag fixes this.
Signed-off-by: Michel Marti <mma@objectxp.com>
---
arch/arm/boot/dts/at91sam9260.dtsi | 1 -
arch/arm/boot/dts/at91sam9263.dtsi | 1 -
arch/arm/boot/dts/at91sam9g45.dtsi | 1 -
arch/arm/boot/dts/at91sam9n12.dtsi | 1 -
arch/arm/boot/dts/at91sam9x5.dtsi | 1 -
arch/arm/boot/dts/sama5d3.dtsi | 1 -
6 files changed, 6 deletions(-)
diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
index dd1313c..184e1d1 100644
--- a/arch/arm/boot/dts/at91sam9260.dtsi
+++ b/arch/arm/boot/dts/at91sam9260.dtsi
@@ -971,7 +971,6 @@
atmel,watchdog-type = "hardware";
atmel,reset-type = "all";
atmel,dbg-halt;
- atmel,idle-halt;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
index 1467750..c39556b 100644
--- a/arch/arm/boot/dts/at91sam9263.dtsi
+++ b/arch/arm/boot/dts/at91sam9263.dtsi
@@ -874,7 +874,6 @@
atmel,watchdog-type = "hardware";
atmel,reset-type = "all";
atmel,dbg-halt;
- atmel,idle-halt;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
index 2a8da8a..b8d741d 100644
--- a/arch/arm/boot/dts/at91sam9g45.dtsi
+++ b/arch/arm/boot/dts/at91sam9g45.dtsi
@@ -1111,7 +1111,6 @@
atmel,watchdog-type = "hardware";
atmel,reset-type = "all";
atmel,dbg-halt;
- atmel,idle-halt;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/at91sam9n12.dtsi b/arch/arm/boot/dts/at91sam9n12.dtsi
index 68eb9ad..e0b5c24 100644
--- a/arch/arm/boot/dts/at91sam9n12.dtsi
+++ b/arch/arm/boot/dts/at91sam9n12.dtsi
@@ -889,7 +889,6 @@
atmel,watchdog-type = "hardware";
atmel,reset-type = "all";
atmel,dbg-halt;
- atmel,idle-halt;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
index bbb3ba6..ce61f91 100644
--- a/arch/arm/boot/dts/at91sam9x5.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
@@ -1125,7 +1125,6 @@
atmel,watchdog-type = "hardware";
atmel,reset-type = "all";
atmel,dbg-halt;
- atmel,idle-halt;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
index 5f4144d..63d12ed 100644
--- a/arch/arm/boot/dts/sama5d3.dtsi
+++ b/arch/arm/boot/dts/sama5d3.dtsi
@@ -1224,7 +1224,6 @@
atmel,watchdog-type = "hardware";
atmel,reset-type = "all";
atmel,dbg-halt;
- atmel,idle-halt;
status = "disabled";
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: at91/dt: keep watchdog running in idle mode
2014-12-23 11:41 [PATCH] ARM: at91/dt: keep watchdog running in idle mode Michel Marti
@ 2015-03-04 10:04 ` Boris Brezillon
2015-03-04 10:18 ` Sylvain Rochet
1 sibling, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2015-03-04 10:04 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 23 Dec 2014 12:41:43 +0100
Michel Marti <mma@objectxp.com> wrote:
> Since turning on idle-halt in commit fe46aa679, SoCs compatible with
> the sam9 watchdog no longer reboot if the wdt times out. Removing the
> 'idle-halt' flag fixes this.
>
> Signed-off-by: Michel Marti <mma@objectxp.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> arch/arm/boot/dts/at91sam9260.dtsi | 1 -
> arch/arm/boot/dts/at91sam9263.dtsi | 1 -
> arch/arm/boot/dts/at91sam9g45.dtsi | 1 -
> arch/arm/boot/dts/at91sam9n12.dtsi | 1 -
> arch/arm/boot/dts/at91sam9x5.dtsi | 1 -
> arch/arm/boot/dts/sama5d3.dtsi | 1 -
> 6 files changed, 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
> index dd1313c..184e1d1 100644
> --- a/arch/arm/boot/dts/at91sam9260.dtsi
> +++ b/arch/arm/boot/dts/at91sam9260.dtsi
> @@ -971,7 +971,6 @@
> atmel,watchdog-type = "hardware";
> atmel,reset-type = "all";
> atmel,dbg-halt;
> - atmel,idle-halt;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/at91sam9263.dtsi b/arch/arm/boot/dts/at91sam9263.dtsi
> index 1467750..c39556b 100644
> --- a/arch/arm/boot/dts/at91sam9263.dtsi
> +++ b/arch/arm/boot/dts/at91sam9263.dtsi
> @@ -874,7 +874,6 @@
> atmel,watchdog-type = "hardware";
> atmel,reset-type = "all";
> atmel,dbg-halt;
> - atmel,idle-halt;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
> index 2a8da8a..b8d741d 100644
> --- a/arch/arm/boot/dts/at91sam9g45.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi
> @@ -1111,7 +1111,6 @@
> atmel,watchdog-type = "hardware";
> atmel,reset-type = "all";
> atmel,dbg-halt;
> - atmel,idle-halt;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/at91sam9n12.dtsi b/arch/arm/boot/dts/at91sam9n12.dtsi
> index 68eb9ad..e0b5c24 100644
> --- a/arch/arm/boot/dts/at91sam9n12.dtsi
> +++ b/arch/arm/boot/dts/at91sam9n12.dtsi
> @@ -889,7 +889,6 @@
> atmel,watchdog-type = "hardware";
> atmel,reset-type = "all";
> atmel,dbg-halt;
> - atmel,idle-halt;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> index bbb3ba6..ce61f91 100644
> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> @@ -1125,7 +1125,6 @@
> atmel,watchdog-type = "hardware";
> atmel,reset-type = "all";
> atmel,dbg-halt;
> - atmel,idle-halt;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
> index 5f4144d..63d12ed 100644
> --- a/arch/arm/boot/dts/sama5d3.dtsi
> +++ b/arch/arm/boot/dts/sama5d3.dtsi
> @@ -1224,7 +1224,6 @@
> atmel,watchdog-type = "hardware";
> atmel,reset-type = "all";
> atmel,dbg-halt;
> - atmel,idle-halt;
> status = "disabled";
> };
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: at91/dt: keep watchdog running in idle mode
2014-12-23 11:41 [PATCH] ARM: at91/dt: keep watchdog running in idle mode Michel Marti
2015-03-04 10:04 ` Boris Brezillon
@ 2015-03-04 10:18 ` Sylvain Rochet
2015-03-04 10:22 ` Nicolas Ferre
1 sibling, 1 reply; 4+ messages in thread
From: Sylvain Rochet @ 2015-03-04 10:18 UTC (permalink / raw)
To: linux-arm-kernel
Hello Nicolas, Michel,
On Tue, Dec 23, 2014 at 12:41:43PM +0100, Michel Marti wrote:
> Since turning on idle-halt in commit fe46aa679, SoCs compatible with
> the sam9 watchdog no longer reboot if the wdt times out. Removing the
> 'idle-halt' flag fixes this.
I missed that and I did exactly the same recently in my "[PATCHv2 0/2]
dts: AT91 Watchdog, remove property idle halt by default", first come,
first serve:
Acked-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
But my patch summary is IMHO better (even with my broken english ;-).
Sylvain
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: at91/dt: keep watchdog running in idle mode
2015-03-04 10:18 ` Sylvain Rochet
@ 2015-03-04 10:22 ` Nicolas Ferre
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Ferre @ 2015-03-04 10:22 UTC (permalink / raw)
To: linux-arm-kernel
Le 04/03/2015 11:18, Sylvain Rochet a ?crit :
> Hello Nicolas, Michel,
>
> On Tue, Dec 23, 2014 at 12:41:43PM +0100, Michel Marti wrote:
>> Since turning on idle-halt in commit fe46aa679, SoCs compatible with
>> the sam9 watchdog no longer reboot if the wdt times out. Removing the
>> 'idle-halt' flag fixes this.
>
> I missed that and I did exactly the same recently in my "[PATCHv2 0/2]
> dts: AT91 Watchdog, remove property idle halt by default", first come,
> first serve:
>
> Acked-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
>
> But my patch summary is IMHO better (even with my broken english ;-).
I try to take it for at91-4.0-at91 and mix the 2 commit messages.
+ I take your documentation of the DT property.
Thanks, bye,
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-04 10:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-23 11:41 [PATCH] ARM: at91/dt: keep watchdog running in idle mode Michel Marti
2015-03-04 10:04 ` Boris Brezillon
2015-03-04 10:18 ` Sylvain Rochet
2015-03-04 10:22 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).