From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.trumtrar@pengutronix.de (Steffen Trumtrar) Date: Wed, 4 Mar 2015 11:23:42 +0100 Subject: [BUG] ARM: socfpga: L2 cache init In-Reply-To: References: <54D8E3BB.3060505@opensource.altera.com> <20150209185820.GB7994@pengutronix.de> <20150209213017.GC7994@pengutronix.de> <54DD2BB3.3090507@opensource.altera.com> <20150213080106.GD7994@pengutronix.de> <20150217222817.GS8656@n2100.arm.linux.org.uk> <20150225092657.GU8656@n2100.arm.linux.org.uk> Message-ID: <20150304102342.GA14613@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Feb 25, 2015 at 10:30:32AM -0600, Dinh Nguyen wrote: > On Wed, Feb 25, 2015 at 3:26 AM, Russell King - ARM Linux > wrote: > > On Tue, Feb 24, 2015 at 05:55:05PM -0600, Dinh Nguyen wrote: > >> Do you have a recommendation on what should be done? > > > > Please try this: > > > > arch/arm/mach-socfpga/socfpga.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c > > index 383d61e138af..f5e597c207b9 100644 > > --- a/arch/arm/mach-socfpga/socfpga.c > > +++ b/arch/arm/mach-socfpga/socfpga.c > > @@ -23,6 +23,7 @@ > > #include > > #include > > #include > > +#include > > > > #include "core.h" > > > > @@ -73,6 +74,10 @@ void __init socfpga_sysmgr_init(void) > > (u32 *) &socfpga_cpu1start_addr)) > > pr_err("SMP: Need cpu1-start-addr in device tree.\n"); > > > > + /* Ensure that socfpga_cpu1start_addr is visible to other CPUs */ > > + smp_wmb(); > > + sync_cache_w(&socfpga_cpu1start_addr); > > + > > sys_manager_base_addr = of_iomap(np, 0); > > > > np = of_find_compatible_node(NULL, NULL, "altr,rst-mgr"); > > > > -- > > > Thanks Russell! I have been able to run the test for > 30 minutes now > with both cores coming up just fine. > > Do you mind taking this patch for 4.0-rc? If so, > > Tested-by: Dinh Nguyen > > Steffen, if you don't mind, do you want to test on your setup as well? Looks good for me, too: Tested-by: Steffen Trumtrar Thanks, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |