From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM64: Add new Xilinx ZynqMP SoC
Date: Thu, 5 Mar 2015 15:03:22 +0100 [thread overview]
Message-ID: <20150305150322.19e378d9@free-electrons.com> (raw)
In-Reply-To: <cd616fa25dafee38f98e3b207e74450c5403f440.1425563597.git.michal.simek@xilinx.com>
Dear Michal Simek,
On Thu, 5 Mar 2015 14:53:34 +0100, Michal Simek wrote:
> + pmu {
> + compatible = "arm,armv8-pmuv3";
> + interrupts = <0 143 4>,
> + <0 144 4>,
> + <0 145 4>,
> + <0 146 4>;
Any reason not to use
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/interrupt-controller/irq.h>
in order to write the more descriptive:
interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;
And ditto for all other interrupts properties?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-05 14:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 13:53 [PATCH v2] ARM64: Add new Xilinx ZynqMP SoC Michal Simek
2015-03-05 14:03 ` Thomas Petazzoni [this message]
2015-03-05 14:08 ` Michal Simek
2015-03-05 14:05 ` Marc Zyngier
2015-03-05 14:27 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305150322.19e378d9@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox