linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH roundup 2/4] ARM: KVM: avoid "HYP init code too big" error
Date: Mon, 9 Mar 2015 19:09:47 +0000	[thread overview]
Message-ID: <20150309190947.GF8656@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1425652482-31411-3-git-send-email-ard.biesheuvel@linaro.org>

On Fri, Mar 06, 2015 at 03:34:40PM +0100, Ard Biesheuvel wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> When building large kernels, the linker will emit lots of veneers
> into the .hyp.idmap.text section, which causes it to grow beyond
> one page, and that triggers the build error.
> 
> This moves the section into .rodata instead, which avoids the
> veneers and is safe because the code is not executed directly
> but remapped by the hypervisor into its own executable address
> space.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> [ardb: move the ALIGN() to .rodata as well, update log s/copied/remapped/]
> Tested-by: Marc Zyngier <marc.zyngier@arm.com>
> Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  arch/arm/kernel/vmlinux.lds.S | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/kernel/vmlinux.lds.S b/arch/arm/kernel/vmlinux.lds.S
> index b31aa73e8076..2787eb8d3616 100644
> --- a/arch/arm/kernel/vmlinux.lds.S
> +++ b/arch/arm/kernel/vmlinux.lds.S
> @@ -22,11 +22,15 @@
>  	ALIGN_FUNCTION();						\
>  	VMLINUX_SYMBOL(__idmap_text_start) = .;				\
>  	*(.idmap.text)							\
> -	VMLINUX_SYMBOL(__idmap_text_end) = .;				\
> +	VMLINUX_SYMBOL(__idmap_text_end) = .;
> +
> +#define IDMAP_RODATA							\
> +	.rodata : {							\

We already have a .rodata section defined by RO_DATA().  Quite how this
interacts with the existing .rodata section, I don't know, but it
probably won't be right.  Have you checked what effect this has?

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-03-09 19:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06 14:34 [PATCH roundup 0/4] extend VA range of ID map for core kernel and KVM Ard Biesheuvel
2015-03-06 14:34 ` [PATCH roundup 1/4] arm64: mm: increase VA range of identity map Ard Biesheuvel
2015-03-16 14:28   ` Christoffer Dall
2015-03-16 14:39     ` Ard Biesheuvel
2015-03-06 14:34 ` [PATCH roundup 2/4] ARM: KVM: avoid "HYP init code too big" error Ard Biesheuvel
2015-03-09 19:09   ` Russell King - ARM Linux [this message]
2015-03-10  9:56     ` Ard Biesheuvel
2015-03-06 14:34 ` [PATCH roundup 3/4] ARM, arm64: kvm: get rid of the bounce page Ard Biesheuvel
2015-03-06 14:34 ` [PATCH roundup 4/4] arm64: KVM: use ID map with increased VA range if required Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150309190947.GF8656@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).