From: fengguang.wu@intel.com (Fengguang Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be static
Date: Tue, 10 Mar 2015 11:41:39 +0800 [thread overview]
Message-ID: <20150310034139.GA17221@wfg-t540p.sh.intel.com> (raw)
In-Reply-To: <20150205171159.GY21293@sirena.org.uk>
On Thu, Feb 05, 2015 at 05:11:59PM +0000, Mark Brown wrote:
> On Fri, Feb 06, 2015 at 01:03:52AM +0800, kbuild test robot wrote:
> > sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' was not declared. Should it be static?
>
> This file isn't in an upstream tree, should this patch have been sent
> upstream (I suspect non-upstream trees may need a bit of filtering in
> the scripts)?
Good point! I just added some tests trying to avoid this, which should
be much better, but nevertheless not complete enough to cover all cases.
Please help point out inadequate cases when you come across them in future!
Thanks,
Fengguang
prev parent reply other threads:[~2015-03-10 3:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 17:03 [baohua:sirf-3.18 2573/2782] sound/soc/sirf/atlas7-iacc.c:168:24: sparse: symbol 'atlas7_iacc_dai_ops' was not declared. Should it be static? kbuild test robot
2015-02-05 17:03 ` [PATCH baohua] ASoC: sirf: atlas7: atlas7_iacc_dai_ops can be static kbuild test robot
2015-02-05 17:11 ` Mark Brown
2015-02-06 2:35 ` [alsa-devel] " Barry Song
2015-03-10 3:41 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310034139.GA17221@wfg-t540p.sh.intel.com \
--to=fengguang.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox