linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91
Date: Tue, 10 Mar 2015 16:23:53 -0500	[thread overview]
Message-ID: <20150310212353.GI25666@saruman.tx.rr.com> (raw)
In-Reply-To: <20150310212122.GJ9188@piout.net>

On Tue, Mar 10, 2015 at 10:21:22PM +0100, Alexandre Belloni wrote:
> On 10/03/2015 at 15:53:12 -0500, Felipe Balbi wrote :
> > On Tue, Mar 03, 2015 at 10:41:38AM +0100, Alexandre Belloni wrote:
> > > On 03/03/2015 at 09:26:20 +0100, Boris Brezillon wrote :
> > > > >  config USB_ATMEL_USBA
> > > > >  	tristate "Atmel USBA"
> > > > > -	depends on AVR32 || ARCH_AT91
> > > > > +	depends on AVR32 || ARCH_AT91 && COMMON_CLK_AT91
> > > > 
> > > > I guess you should add parenthesis to make it clearer ?
> > > > 
> > > > 	depends on AVR32 || (ARCH_AT91 && COMMON_CLK_AT91)
> > > > 
> > > > And I wonder why you need that. I though this option was selected by all
> > > > at91 platforms ?
> > > > 
> > > 
> > > That is currently the case but maybe, one day, one of the AT91 platform
> > > will not use the same clock driver.
> > 
> > then, maybe, one day, you send this patch.
> 
> Yeah, let's drop it for now but I have the feeling that this will
> break (I actually broke it when switching at91 to multiplatform).

aha, that changes it. So you already have something which makes this
break ? Are you planning on sending that upstream any time soon ?

We could very well use that same series to merge this patch. Only when
it's needed ;-)

cheers

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150310/88511924/attachment.sig>

  reply	other threads:[~2015-03-10 21:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03  7:42 [PATCH] udc: gadget: atmel_usba_udc: depend on COMMON_CLK_AT91 Alexandre Belloni
2015-03-03  8:26 ` Boris Brezillon
2015-03-03  9:41   ` Alexandre Belloni
2015-03-10 20:53     ` Felipe Balbi
2015-03-10 21:21       ` Alexandre Belloni
2015-03-10 21:23         ` Felipe Balbi [this message]
2015-03-10 21:41           ` Alexandre Belloni
2015-03-10 21:41             ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150310212353.GI25666@saruman.tx.rr.com \
    --to=balbi@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).