linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] mtd: cfi: reduce stack size
Date: Tue, 10 Mar 2015 22:00:14 +0100	[thread overview]
Message-ID: <201503102200.16344.arnd@arndb.de> (raw)
In-Reply-To: <20150310194126.GC4124@norris-Latitude-E6410>

On Tuesday 10 March 2015, Brian Norris wrote:
> On Tue, Mar 10, 2015 at 05:48:37PM +0100, Arnd Bergmann wrote:
> > The cfi_staa_write_buffers function uses a large amount of kernel stack
> > whenever CONFIG_MTD_MAP_BANK_WIDTH_32 is set, and that results in a
> > warning on ARM allmodconfig builds:
> > 
> > drivers/mtd/chips/cfi_cmdset_0020.c: In function 'cfi_staa_write_buffers':
> > drivers/mtd/chips/cfi_cmdset_0020.c:651:1: warning: the frame size of 1208 bytes is larger than 1024 bytes [-Wframe-larger-than=]
> > 
> > It turns out that this is largely a result of a suboptimal implementation
> > of map_word_andequal(). Replacing this function with a straightforward
> > one reduces the stack size in this function by exactly 200 bytes,
> > shrinks the .text segment for this file from 27648 bytes to 26608 bytes,
> > and makes the warning go away.
> 
> Patch looks OK to me, and those results are nice.
> 
> Did you (or anyone else) do any testing?

No runtime tests, I only built them, sorry.

	Arnd

  reply	other threads:[~2015-03-10 21:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 16:48 [PATCH v3] mtd: cfi: reduce stack size Arnd Bergmann
2015-03-10 16:51 ` [PATCH] mtd: clean up whitespace in linux/mtd/map.h Arnd Bergmann
2015-03-10 18:33   ` Joe Perches
2015-03-10 19:58     ` Brian Norris
2015-03-10 20:28       ` Joe Perches
2015-03-11 23:50   ` Brian Norris
2015-03-10 19:41 ` [PATCH v3] mtd: cfi: reduce stack size Brian Norris
2015-03-10 21:00   ` Arnd Bergmann [this message]
2015-03-11 23:49 ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201503102200.16344.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).