[PATCH] pinctrl: sun4i: GPIOs configured as irq must be set to input before reading

Linus Walleij
2015-03-18T09:57:29Z

On Sun, Mar 8, 2015 at 10:13 PM, Hans de Goede <hdegoede@redhat.com> wrote:

> On sun4i-a10, when GPIOs are configured as external interrupt the value for
> them in the data register does not seem to get updated, so set their mux to
> input (and restore afterwards) when reading the pin.
>
> Missed edges seem to be buffered, so this does not introduce a race
> condition.
>
> I've also tested this on sun5i-a13 and sun7i-a20 and those do not seem to
> be affected, the input value representation in the data register does seem
> to correctly get updated to the actual pin value while in irq mode there.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Patch applied for fixes with Maxime's ACK.

Yours,
Linus Walleij