[PATCH 1/2] ARM: imx6qdl-sabresd: set swbst_reg as vbus's parent reg

[PATCH 1/2] ARM: imx6qdl-sabresd: set swbst_reg as vbus's parent reg

[Peter Chen]

USB vbus 5V is from PMIC SWBST, so set swbst_reg as vbus's
parent reg, it fixed a bug that the voltage of vbus is incorrect
due to swbst_reg is disabled after boots up.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index f1cd214..a626e6d 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -35,6 +35,7 @@
 			regulator-max-microvolt = <5000000>;
 			gpio = <&gpio3 22 0>;
 			enable-active-high;
+			vin-supply = <&swbst_reg>;
 		};
 
 		reg_usb_h1_vbus: regulator at 1 {
@@ -45,6 +46,7 @@
 			regulator-max-microvolt = <5000000>;
 			gpio = <&gpio1 29 0>;
 			enable-active-high;
+			vin-supply = <&swbst_reg>;
 		};
 
 		reg_audio: regulator at 2 {
-- 
1.9.1

[PATCH 2/2] ARM: imx6sl-evk: set swbst_reg as vbus's parent reg

[Peter Chen]

USB vbus 5V is from PMIC SWBST, so set swbst_reg as vbus's
parent reg, it fixed a bug that the voltage of vbus is incorrect
due to swbst_reg is disabled after boots up.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
 arch/arm/boot/dts/imx6sl-evk.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sl-evk.dts b/arch/arm/boot/dts/imx6sl-evk.dts
index fda4932..945887d 100644
--- a/arch/arm/boot/dts/imx6sl-evk.dts
+++ b/arch/arm/boot/dts/imx6sl-evk.dts
@@ -52,6 +52,7 @@
 			regulator-max-microvolt = <5000000>;
 			gpio = <&gpio4 0 0>;
 			enable-active-high;
+			vin-supply = <&swbst_reg>;
 		};
 
 		reg_usb_otg2_vbus: regulator at 1 {
@@ -62,6 +63,7 @@
 			regulator-max-microvolt = <5000000>;
 			gpio = <&gpio4 2 0>;
 			enable-active-high;
+			vin-supply = <&swbst_reg>;
 		};
 
 		reg_aud3v: regulator at 2 {
-- 
1.9.1

[PATCH 1/2] ARM: imx6qdl-sabresd: set swbst_reg as vbus's parent reg

[Shawn Guo]

On Fri, Mar 06, 2015 at 04:04:20PM +0800, Peter Chen wrote:
> USB vbus 5V is from PMIC SWBST, so set swbst_reg as vbus's
> parent reg, it fixed a bug that the voltage of vbus is incorrect
> due to swbst_reg is disabled after boots up.
> 
> Cc: stable <stable@vger.kernel.org>

It's more idiomatic to put the line in this way:

Cc: stable at vger.kernel.org

Changed it and applied both patches.

Shawn

> Signed-off-by: Peter Chen <peter.chen@freescale.com>
> ---
>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index f1cd214..a626e6d 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -35,6 +35,7 @@
>  			regulator-max-microvolt = <5000000>;
>  			gpio = <&gpio3 22 0>;
>  			enable-active-high;
> +			vin-supply = <&swbst_reg>;
>  		};
>  
>  		reg_usb_h1_vbus: regulator at 1 {
> @@ -45,6 +46,7 @@
>  			regulator-max-microvolt = <5000000>;
>  			gpio = <&gpio1 29 0>;
>  			enable-active-high;
> +			vin-supply = <&swbst_reg>;
>  		};
>  
>  		reg_audio: regulator at 2 {
> -- 
> 1.9.1
> 

[PATCH 1/2] ARM: imx6qdl-sabresd: set swbst_reg as vbus's parent reg

[Greg KH]

On Wed, Mar 11, 2015 at 09:24:25AM +0800, Shawn Guo wrote:
> On Fri, Mar 06, 2015 at 04:04:20PM +0800, Peter Chen wrote:
> > USB vbus 5V is from PMIC SWBST, so set swbst_reg as vbus's
> > parent reg, it fixed a bug that the voltage of vbus is incorrect
> > due to swbst_reg is disabled after boots up.
> > 
> > Cc: stable <stable@vger.kernel.org>
> 
> It's more idiomatic to put the line in this way:
> 
> Cc: stable at vger.kernel.org
> 
> Changed it and applied both patches.

It really doesn't matter, my scripts try to pick up any variation of the
stable@ markings in a signed-off-by: area, as there is a huge number of
different ways people try to mark this, including using invalid email
addresses, and typos.

So no need to be pedantic about this, I can handle it just fine.

thanks,

greg k-h

[PATCH 1/2] ARM: imx6qdl-sabresd: set swbst_reg as vbus's parent reg

[Peter Chen]

On Wed, Mar 11, 2015 at 09:24:25AM +0800, Shawn Guo wrote:
> On Fri, Mar 06, 2015 at 04:04:20PM +0800, Peter Chen wrote:
> > USB vbus 5V is from PMIC SWBST, so set swbst_reg as vbus's
> > parent reg, it fixed a bug that the voltage of vbus is incorrect
> > due to swbst_reg is disabled after boots up.
> > 
> > Cc: stable <stable@vger.kernel.org>
> 
> It's more idiomatic to put the line in this way:
> 
> Cc: stable at vger.kernel.org
> 

One benefit for using <stable@vger.kernel.org> over than
stable at vger.kernel.org directly is it can add "# v3.x+"
at the last of Cc tag if you want git send Cc tag.

Cc: <stable@vger.kernel.org> #3.x+ /* git can work */

Cc: stable at vger.kernel.org #3.x+ /* git can't work */

-- 

Best Regards,
Peter Chen

[PATCH 1/2] ARM: imx6qdl-sabresd: set swbst_reg as vbus's parent reg

[Shawn Guo]

On Thu, Mar 12, 2015 at 09:54:18AM +0800, Peter Chen wrote:
> On Wed, Mar 11, 2015 at 09:24:25AM +0800, Shawn Guo wrote:
> > On Fri, Mar 06, 2015 at 04:04:20PM +0800, Peter Chen wrote:
> > > USB vbus 5V is from PMIC SWBST, so set swbst_reg as vbus's
> > > parent reg, it fixed a bug that the voltage of vbus is incorrect
> > > due to swbst_reg is disabled after boots up.
> > > 
> > > Cc: stable <stable@vger.kernel.org>
> > 
> > It's more idiomatic to put the line in this way:
> > 
> > Cc: stable at vger.kernel.org
> > 
> 
> One benefit for using <stable@vger.kernel.org> over than
> stable at vger.kernel.org directly is it can add "# v3.x+"
> at the last of Cc tag if you want git send Cc tag.
> 
> Cc: <stable@vger.kernel.org> #3.x+ /* git can work */
> 
> Cc: stable at vger.kernel.org #3.x+ /* git can't work */

Yeah, that's true.  What I was really questioning is not
< >, but the alias 'stable' right before it.

Shawn