From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/22] ARM: %pF is only for function pointers
Date: Thu, 12 Mar 2015 19:51:16 +0000 [thread overview]
Message-ID: <20150312195116.GV8656@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1426130037-17956-8-git-send-email-scottwood@freescale.com>
On Wed, Mar 11, 2015 at 10:13:43PM -0500, Scott Wood wrote:
> Use %pS for actual addresses, otherwise you'll get bad output
> on arches like ppc64 where %pF expects a function descriptor. Even on
> other architectures, refrain from setting a bad example that people
> copy.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Cc: linux-arm-kernel at lists.infradead.org
Would've been nice to have been Cc'd on the patch, but luckily I saw it
amongst all the traffic anyway. If the trivial folk want to take it:
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Thanks.
> ---
> arch/arm/mm/alignment.c | 2 +-
> arch/arm/nwfpe/fpmodule.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mm/alignment.c b/arch/arm/mm/alignment.c
> index 2c0c541..3419550 100644
> --- a/arch/arm/mm/alignment.c
> +++ b/arch/arm/mm/alignment.c
> @@ -132,7 +132,7 @@ static const char *usermode_action[] = {
> static int alignment_proc_show(struct seq_file *m, void *v)
> {
> seq_printf(m, "User:\t\t%lu\n", ai_user);
> - seq_printf(m, "System:\t\t%lu (%pF)\n", ai_sys, ai_sys_last_pc);
> + seq_printf(m, "System:\t\t%lu (%pS)\n", ai_sys, ai_sys_last_pc);
> seq_printf(m, "Skipped:\t%lu\n", ai_skipped);
> seq_printf(m, "Half:\t\t%lu\n", ai_half);
> seq_printf(m, "Word:\t\t%lu\n", ai_word);
> diff --git a/arch/arm/nwfpe/fpmodule.c b/arch/arm/nwfpe/fpmodule.c
> index ec717c1..2d2bfe2 100644
> --- a/arch/arm/nwfpe/fpmodule.c
> +++ b/arch/arm/nwfpe/fpmodule.c
> @@ -147,7 +147,7 @@ void float_raise(signed char flags)
> #ifdef CONFIG_DEBUG_USER
> if (flags & debug)
> printk(KERN_DEBUG
> - "NWFPE: %s[%d] takes exception %08x at %pf from %08lx\n",
> + "NWFPE: %s[%d] takes exception %08x at %ps from %08lx\n",
> current->comm, current->pid, flags,
> __builtin_return_address(0), GET_USERREG()->ARM_pc);
> #endif
> --
> 2.1.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
prev parent reply other threads:[~2015-03-12 19:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1426130037-17956-1-git-send-email-scottwood@freescale.com>
2015-03-12 3:13 ` [PATCH 08/22] ARM: %pF is only for function pointers Scott Wood
2015-03-12 19:51 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312195116.GV8656@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).