* [PATCH] ARM: mvebu: clk: remove cpuclk resources overlapping coredivclk registers on Armada XP
@ 2015-03-17 12:53 Gregory CLEMENT
2015-03-18 15:57 ` Gregory CLEMENT
2015-03-18 16:02 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2015-03-17 12:53 UTC (permalink / raw)
To: linux-arm-kernel
From: Nadav Haklai <nadavh@marvell.com>
The resources of the cpuclk node are overlapping the one from
coredivclk node. It was not noticed until now because the driver did a
simple of_iomap and not a request_mem_region. This patch fixes it.
[gregory.clement at free-electrons.com: add commit log and port to 4.0-rc]
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Nadav Haklai <nadavh@marvell.com>
Signed-off-by: Nadav Haklai <nadavh@marvell.com>
---
arch/arm/boot/dts/armada-xp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi
index 82917236a2fb..fdc2e5bdf459 100644
--- a/arch/arm/boot/dts/armada-xp.dtsi
+++ b/arch/arm/boot/dts/armada-xp.dtsi
@@ -149,7 +149,7 @@
cpuclk: clock-complex at 18700 {
#clock-cells = <1>;
compatible = "marvell,armada-xp-cpu-clock";
- reg = <0x18700 0xA0>, <0x1c054 0x10>;
+ reg = <0x18700 0x24>, <0x1c054 0x10>;
clocks = <&coreclk 1>;
};
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: mvebu: clk: remove cpuclk resources overlapping coredivclk registers on Armada XP
2015-03-17 12:53 [PATCH] ARM: mvebu: clk: remove cpuclk resources overlapping coredivclk registers on Armada XP Gregory CLEMENT
@ 2015-03-18 15:57 ` Gregory CLEMENT
2015-03-18 16:02 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2015-03-18 15:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 17/03/2015 13:53, Gregory CLEMENT wrote:
> From: Nadav Haklai <nadavh@marvell.com>
>
> The resources of the cpuclk node are overlapping the one from
> coredivclk node. It was not noticed until now because the driver did a
> simple of_iomap and not a request_mem_region. This patch fixes it.
unless someone is against it, I will apply it on mvebu/dt tomorrow.
Thanks,
Gregory
>
> [gregory.clement at free-electrons.com: add commit log and port to 4.0-rc]
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Signed-off-by: Nadav Haklai <nadavh@marvell.com>
> Signed-off-by: Nadav Haklai <nadavh@marvell.com>
> ---
> arch/arm/boot/dts/armada-xp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi
> index 82917236a2fb..fdc2e5bdf459 100644
> --- a/arch/arm/boot/dts/armada-xp.dtsi
> +++ b/arch/arm/boot/dts/armada-xp.dtsi
> @@ -149,7 +149,7 @@
> cpuclk: clock-complex at 18700 {
> #clock-cells = <1>;
> compatible = "marvell,armada-xp-cpu-clock";
> - reg = <0x18700 0xA0>, <0x1c054 0x10>;
> + reg = <0x18700 0x24>, <0x1c054 0x10>;
> clocks = <&coreclk 1>;
> };
>
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: mvebu: clk: remove cpuclk resources overlapping coredivclk registers on Armada XP
2015-03-17 12:53 [PATCH] ARM: mvebu: clk: remove cpuclk resources overlapping coredivclk registers on Armada XP Gregory CLEMENT
2015-03-18 15:57 ` Gregory CLEMENT
@ 2015-03-18 16:02 ` Thomas Petazzoni
2015-03-19 10:12 ` Gregory CLEMENT
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2015-03-18 16:02 UTC (permalink / raw)
To: linux-arm-kernel
Dear Gregory CLEMENT,
On Tue, 17 Mar 2015 13:53:34 +0100, Gregory CLEMENT wrote:
> From: Nadav Haklai <nadavh@marvell.com>
>
> The resources of the cpuclk node are overlapping the one from
> coredivclk node. It was not noticed until now because the driver did a
> simple of_iomap and not a request_mem_region. This patch fixes it.
>
> [gregory.clement at free-electrons.com: add commit log and port to 4.0-rc]
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Signed-off-by: Nadav Haklai <nadavh@marvell.com>
> Signed-off-by: Nadav Haklai <nadavh@marvell.com>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: mvebu: clk: remove cpuclk resources overlapping coredivclk registers on Armada XP
2015-03-18 16:02 ` Thomas Petazzoni
@ 2015-03-19 10:12 ` Gregory CLEMENT
0 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2015-03-19 10:12 UTC (permalink / raw)
To: linux-arm-kernel
On 18/03/2015 17:02, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
>
> On Tue, 17 Mar 2015 13:53:34 +0100, Gregory CLEMENT wrote:
>> From: Nadav Haklai <nadavh@marvell.com>
>>
>> The resources of the cpuclk node are overlapping the one from
>> coredivclk node. It was not noticed until now because the driver did a
>> simple of_iomap and not a request_mem_region. This patch fixes it.
>>
>> [gregory.clement at free-electrons.com: add commit log and port to 4.0-rc]
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> Signed-off-by: Nadav Haklai <nadavh@marvell.com>
>> Signed-off-by: Nadav Haklai <nadavh@marvell.com>
>
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
applied on mvebu/dt with Thomas tag
Thanks,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-19 10:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-17 12:53 [PATCH] ARM: mvebu: clk: remove cpuclk resources overlapping coredivclk registers on Armada XP Gregory CLEMENT
2015-03-18 15:57 ` Gregory CLEMENT
2015-03-18 16:02 ` Thomas Petazzoni
2015-03-19 10:12 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).