linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: edubezval@gmail.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] ti-soc-thermal: request temperature periodically if hw can't do that itself
Date: Tue, 24 Mar 2015 12:30:34 -0400	[thread overview]
Message-ID: <20150324163032.GA13813@developer.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20150118202447.GA29014@amd>

On Sun, Jan 18, 2015 at 09:24:47PM +0100, Pavel Machek wrote:
> 
> When periodic mode is not enabled, it is neccessary to force reads.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

This is a malformed patch. here is patch output (or git am)
patching file drivers/thermal/ti-soc-thermal/ti-bandgap.c
patch: **** malformed patch at line 68: (english)
http://www.livejournal.com/~pavelmachek


I would really recommend you to use git to send your patches to avoid
such problems. Can you please resend this patch in its proper format?


> 
> diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> index 634b6ce..2fde78c 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
> @@ -43,6 +43,8 @@
>  
>  #include "ti-bandgap.h"
>  
> +static int ti_bandgap_force_single_read(struct ti_bandgap *bgp, int id);
> +
>  /***   Helper functions to access registers and their bitfields   ***/
>  
>  /**
> @@ -852,14 +831,21 @@ int ti_bandgap_read_temperature(struct ti_bandgap *bgp, int id,
>  	if (ret)
>  		return ret;
>  
> +	if (!TI_BANDGAP_HAS(bgp, MODE_CONFIG)) {
> +		ret = ti_bandgap_force_single_read(bgp, id);
> +		if (ret)
> +			return ret;
> +	}
> +
>  	spin_lock(&bgp->lock);
>  	temp = ti_bandgap_read_temp(bgp, id);
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150324/c2cd4055/attachment.sig>

  reply	other threads:[~2015-03-24 16:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-03 11:46 [PATCH] ti-soc-thermal: implement eocz bit to make driver useful on omap3 Pavel Machek
2015-01-03 12:26 ` Eduardo Valentin
2015-01-03 16:22   ` Pavel Machek
2015-01-05 21:35     ` Eduardo Valentin
2015-01-18 20:18       ` Pavel Machek
2015-01-21  5:21         ` Eduardo Valentin
2015-01-18 20:20 ` [PATCHv2] " Pavel Machek
2015-01-18 20:24 ` [PATCHv2] ti-soc-thermal: request temperature periodically if hw can't do that itself Pavel Machek
2015-03-24 16:30   ` Eduardo Valentin [this message]
2015-03-24 22:27     ` Pavel Machek
2015-03-24 22:20   ` [PATCHv3] " Pavel Machek
2015-03-31  8:42   ` [PATCH] ti-soc-thermal: implement omap3 support Pavel Machek
2015-03-31 15:02     ` Grazvydas Ignotas
2015-04-02 14:49       ` Pavel Machek
2015-04-02 14:49     ` [PATCHv2] " Pavel Machek
2015-04-07 18:57       ` Eduardo Valentin
2015-04-07 19:09       ` Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150324163032.GA13813@developer.hsd1.ca.comcast.net \
    --to=edubezval@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).