From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: imx25-karo-tx25: Fix pincontrol definition
Date: Wed, 25 Mar 2015 12:09:02 +0100 [thread overview]
Message-ID: <20150325110902.GH32677@pengutronix.de> (raw)
In-Reply-To: <20150325110237.GB5024@pengutronix.de>
Hello Markus,
On Wed, Mar 25, 2015 at 12:02:37PM +0100, Markus Pargmann wrote:
> On Tue, Mar 24, 2015 at 08:50:46PM +0100, Uwe Kleine-K?nig wrote:
> > I think this grouping is a relict from the time when we considered to
> > list the groups in the imx$num.dtsi? I would prefer to "fix" the driver
> > to work with the way imx25-karo-tx25 presents the pinmuxing because I
> > don't see the motivation for this extra grouping. (So let us define the
> > current method of imx25-karo-tx25 as the good one to follow if you ask
> > me.)
>
> But the binding for the pinctrl unit is already defined. I am not sure
> about the policy for changing devicetree bindings. I thought it should
> be avoided?
Allowing more valid definitions shouldn't be a problem, should it?
So don't rip out parsing groups within a namespace, just complement it
with support for namespace-less groups
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-03-25 11:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 14:09 [PATCH 1/2] ARM: dts: imx25: Add #pwm-cells to pwm4 Markus Pargmann
2015-03-24 14:09 ` [PATCH 2/2] ARM: dts: imx25-karo-tx25: Fix pincontrol definition Markus Pargmann
2015-03-24 19:50 ` Uwe Kleine-König
2015-03-25 11:02 ` Markus Pargmann
2015-03-25 11:09 ` Uwe Kleine-König [this message]
2015-03-29 21:26 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150325110902.GH32677@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).