linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: leo.yan@linaro.org (Leo Yan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] cpufreq: hisilicon: add acpu driver
Date: Fri, 27 Mar 2015 10:02:01 +0800	[thread overview]
Message-ID: <20150327020201.GB4902@leoy-linaro> (raw)
In-Reply-To: <55141412.6040600@arm.com>

hi Sudeep,

Thanks for reviewing.

On Thu, Mar 26, 2015 at 02:13:38PM +0000, Sudeep Holla wrote:
> 
> On 26/03/15 11:48, Leo Yan wrote:
> >+static int __init hisi_acpu_cpufreq_driver_init(void)
> >+{
> >+	struct platform_device_info devinfo = { .name = "cpufreq-dt", };
> >+	struct platform_device *pdev;
> >+
> >+	if (!of_machine_is_compatible("hisilicon,hi6220"))
> >+		return -ENODEV;
> >+
> >+	pdev = platform_device_register_full(&devinfo);
> >+	return PTR_ERR_OR_ZERO(pdev);
> 
> Since you are not using anything other than name, you can simplify it
> further by something like:
> 	platform_device_register_simple("cpufreq-dt", -1, NULL, 0)

Will use this way and resend patch.

> And IMO it need not be a separate driver too, you can add this in mach
> if it exists(i.e. arm32 though not recommended) or clock code that
> registers cpu clock. Thoughts ?

This driver will be firstly used for hikey board w/t ARMv8 SoC and i
prefer de-couple the cpufreq driver w/t clk driver. w/t this cpufreq
driver, we can easily enhance it and init SoC's specific operations
for later more hisilicon SoCs.

Thanks,
Leo Yan

      reply	other threads:[~2015-03-27  2:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 11:48 [PATCH v2] cpufreq: hisilicon: add acpu driver Leo Yan
2015-03-26 13:24 ` Viresh Kumar
2015-03-26 14:13 ` Sudeep Holla
2015-03-27  2:02   ` Leo Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150327020201.GB4902@leoy-linaro \
    --to=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).