linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: at91 clocks
Date: Fri, 27 Mar 2015 13:20:03 +0100	[thread overview]
Message-ID: <20150327132003.6caf3689@bbrezillon> (raw)
In-Reply-To: <55152F3E.60004@microbit.se>

Hi Jonas,

On Fri, 27 Mar 2015 11:21:50 +0100
Jonas Andersson <jonas@microbit.se> wrote:

> Hi Boris,
> 
> On 2015-03-26 16:28, Boris Brezillon wrote:
> >>>>>> Hi all,
> >>>>>>
> >>>>>> I am working on a system with at91sam9260 soc. Trying to move from
> >>>>>> kernel 3.17.4 to 3.19.2. I have problem with pck1 clock.
> >>>>>>
> >>>>>> In my old code i use clk_get() to get pck1 and pllb, set pllb as parent
> >>>>>> for pck1, set rate for pck1, enable pck1.
> >>>>> How do you do that (clk_set_parent + clk_set_rate) ?
> >>>>> Could you paste your code somewhere ?
> >>>> Yes, see http://pastie.org/10052161
> > Could you paste the new version of your code (the one with clk_set_rate
> > on pllb) ?
> Added this at http://pastie.org/10057041

Seems good.

> >>> Your pllb seems to be configured to output a 0Hz rate, and I'm not
> >>> forwarding rate change to prog clk parents yet.
> >>> That's definitely something I should work on, but in the meantime you
> >>> could try to manually set pllb rate.
> >> I tried to set pllb rate to 96MHz but it still shows 0Hz. |clk_set_rate
> >> returns 0|.
> > Have you tested pllb pointer value ? As you can see here [1], the CCF
> > is not complaining when you pass a NULL pointer.
> 
> I tested with IS_ERR, changed this to IS_ERR_OR_NULL, but the pointer is ok.

Can you print clk_get_rate(parent_clk) result ?

Best Regards,

Boris


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2015-03-27 12:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 14:32 at91 clocks Jonas Andersson
2015-03-25  0:32 ` Boris Brezillon
2015-03-25  9:06   ` Jonas Andersson
2015-03-25 16:37     ` Boris Brezillon
2015-03-25 18:18       ` Nicolas Ferre
2015-03-27  9:28         ` Jonas Andersson
2015-03-27  9:48           ` Nicolas Ferre
2015-03-26 10:02       ` Jonas Andersson
     [not found]       ` <5513D701.2080201@microbit.se>
2015-03-26 15:28         ` Boris Brezillon
2015-03-27 10:21           ` Jonas Andersson
2015-03-27 12:20             ` Boris Brezillon [this message]
2015-03-27 12:25               ` Boris Brezillon
2015-03-27 12:51                 ` Jonas Andersson
2015-03-27 13:54                   ` Boris Brezillon
2015-03-27 14:42                     ` Jonas Andersson
2015-03-30 11:24                       ` Jonas Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150327132003.6caf3689@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).