From: moorray3@wp.pl (Jakub Kiciński)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/2] serial/amba-pl011: Refactor and simplify TX FIFO handling
Date: Mon, 30 Mar 2015 16:28:11 +0200 [thread overview]
Message-ID: <20150330162811.3673482b@north> (raw)
In-Reply-To: <1427468371-11915-3-git-send-email-Dave.Martin@arm.com>
On Fri, 27 Mar 2015 14:59:31 +0000, Dave Martin wrote:
> Commit 734745c serial/amba-pl011: Activate TX IRQ passively
> adds some unnecessary complexity and overhead in the form of
> a softirq mechanism for transmitting in the absence of interrupts.
>
> After some discussion [1], this turns out to be unnecessary.
>
> This patch simplifies the code flow to reduce the reliance on
> subtle behaviour and avoid fragility under future maintenance.
>
> To this end, the TX softirq mechanism is removed and instead
> pl011_start_tx() will now simply stuff the FIFO until full
> (guaranteeing future TX IRQs), or until there are no more chars
> to write (in which case we don't care whether an IRQ happens).
>
> [1] Thanks to Jakub Kici?ski for his input and similar patch.
>
> Signed-off-by: Dave Martin <Dave.Martin@arm.com>
Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
next prev parent reply other threads:[~2015-03-30 14:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 14:59 [PATCH v4 0/2] serial/amba-pl011: Activate TX IRQ passively (rework) Dave Martin
2015-03-27 14:59 ` [PATCH v4 1/2] Revert "serial/amba-pl011: Leave the TX IRQ alone when the UART is not open" Dave Martin
2015-03-27 14:59 ` [PATCH v4 2/2] serial/amba-pl011: Refactor and simplify TX FIFO handling Dave Martin
2015-03-27 16:40 ` Jakub Kiciński
2015-03-27 17:42 ` Dave P Martin
2015-03-27 18:10 ` Jakub Kiciński
2015-03-30 12:28 ` Dave Martin
2015-03-30 14:26 ` Jakub Kiciński
2015-03-30 16:07 ` Dave Martin
2015-03-30 14:28 ` Jakub Kiciński [this message]
2015-03-30 16:09 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330162811.3673482b@north \
--to=moorray3@wp.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).