From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] clk: make strings in parent name arrays const
Date: Mon, 30 Mar 2015 20:32:34 +0200 [thread overview]
Message-ID: <20150330183234.GH9742@pengutronix.de> (raw)
In-Reply-To: <1427739631.14276.23.camel@perches.com>
On Mon, Mar 30, 2015 at 11:20:31AM -0700, Joe Perches wrote:
> On Mon, 2015-03-30 at 20:16 +0200, Sascha Hauer wrote:
> > On Mon, Mar 30, 2015 at 10:55:19AM -0700, Joe Perches wrote:
> > > On Mon, 2015-03-30 at 19:40 +0200, Sascha Hauer wrote:
> > > > The clk functions and structs declare the parent_name arrays as
> > > > 'const char **parent_names' which means the parent name strings
> > > > are const, but the array itself is not. Use
> > > > 'const char * const * parent_names' instead which also makes
> > > > the array const. This allows us to put the parent_name arrays into
> > > > the __initconst section.
> > >
> > > If these are pointer entries are stored, care needs to be
> > > taken to make sure that the memory isn't discarded or needed
> > > post init.
> >
> > The clock framework makes deep copies of all initialization data
> > structures.
>
> Great. Is/Should that be documented somewhere?
I have no idea if/where this is documented.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2015-03-30 18:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 17:40 [PATCH v10]: clk: Add common clock support for Mediatek MT8135 and MT8173 Sascha Hauer
2015-03-30 17:40 ` [PATCH 1/6] clk: make strings in parent name arrays const Sascha Hauer
2015-03-30 17:55 ` Joe Perches
2015-03-30 18:16 ` Sascha Hauer
2015-03-30 18:20 ` Joe Perches
2015-03-30 18:32 ` Sascha Hauer [this message]
2015-03-30 17:40 ` [PATCH 2/6] clk: mediatek: Add initial common clock support for Mediatek SoCs Sascha Hauer
2015-03-30 17:55 ` Joe Perches
2015-03-30 18:31 ` Sascha Hauer
2015-03-31 1:21 ` Michael Turquette
2015-03-30 17:40 ` [PATCH 3/6] clk: mediatek: Add reset controller support Sascha Hauer
2015-03-31 8:00 ` Philipp Zabel
2015-03-30 17:40 ` [PATCH 4/6] clk: mediatek: Add basic clocks for Mediatek MT8135 Sascha Hauer
2015-03-30 17:40 ` [PATCH 5/6] clk: mediatek: Add basic clocks for Mediatek MT8173 Sascha Hauer
2015-04-13 11:36 ` Matthias Brugger
2015-03-30 17:40 ` [PATCH 6/6] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock/reset controllers Sascha Hauer
2015-03-31 1:33 ` [PATCH v10]: clk: Add common clock support for Mediatek MT8135 and MT8173 Michael Turquette
-- strict thread matches above, loose matches on Subject: below --
2015-04-23 8:35 [PATCH v12] " Sascha Hauer
2015-04-23 8:35 ` [PATCH 1/6] clk: make strings in parent name arrays const Sascha Hauer
2015-04-23 8:48 ` Uwe Kleine-König
2015-03-31 18:16 [PATCH v11]: clk: Add common clock support for Mediatek MT8135 and MT8173 Sascha Hauer
2015-03-31 18:16 ` [PATCH 1/6] clk: make strings in parent name arrays const Sascha Hauer
2015-04-09 7:27 ` Krzysztof Kozlowski
2015-03-27 9:18 [PATCH v9]: clk: Add common clock support for Mediatek MT8135 and MT8173 Sascha Hauer
2015-03-27 9:18 ` [PATCH 1/6] clk: make strings in parent name arrays const Sascha Hauer
2015-03-19 8:42 [PATCH v8]: clk: Add common clock support for Mediatek MT8135 and MT8173 Sascha Hauer
2015-03-19 8:42 ` [PATCH 1/6] clk: make strings in parent name arrays const Sascha Hauer
2015-03-19 8:48 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330183234.GH9742@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).