* [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 @ 2015-03-31 8:18 Aleksei Mamlin 2015-03-31 14:43 ` Maxime Ripard 0 siblings, 1 reply; 12+ messages in thread From: Aleksei Mamlin @ 2015-03-31 8:18 UTC (permalink / raw) To: linux-arm-kernel This patch adds nodes for the Goodix GT911 touchscreen controller found on the Wexler TAB7200 tablet. Controller uses one of following I2C addresses: 0x5d or 0x14, so just add two nodes. Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com> --- DT support for the Goodix GT911 touchscreen controller has been queued up by Dmitry Torokhov for merging into 4.1: https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next&id=771d8f1b178e7e09fcc641fccd48852958dbc329 IRQ flags are set by the touchscreen controller driver, so use IRQ_TYPE_NONE. arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts index 2ad3b09..34e2bce 100644 --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts @@ -101,6 +101,20 @@ pinctrl-names = "default"; pinctrl-0 = <&i2c2_pins_a>; status = "okay"; + + gt911 at 5d { + compatible = "goodix,gt911"; + reg = <0x5d>; + interrupt-parent = <&pio>; + interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */ + }; + + gt911 at 14 { + compatible = "goodix,gt911"; + reg = <0x14>; + interrupt-parent = <&pio>; + interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */ + }; }; &lradc { -- 2.0.5 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 2015-03-31 8:18 [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 Aleksei Mamlin @ 2015-03-31 14:43 ` Maxime Ripard 2015-03-31 19:14 ` Aleksei Mamlin 2015-03-31 19:31 ` Aleksei Mamlin 0 siblings, 2 replies; 12+ messages in thread From: Maxime Ripard @ 2015-03-31 14:43 UTC (permalink / raw) To: linux-arm-kernel Hi, On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote: > This patch adds nodes for the Goodix GT911 touchscreen controller found > on the Wexler TAB7200 tablet. Controller uses one of following I2C > addresses: 0x5d or 0x14, so just add two nodes. In which case are these different addresses encountered? Different revisions of the same board? > Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com> > --- > DT support for the Goodix GT911 touchscreen controller has been queued up > by Dmitry Torokhov for merging into 4.1: > https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next&id=771d8f1b178e7e09fcc641fccd48852958dbc329 > > IRQ flags are set by the touchscreen controller driver, so use IRQ_TYPE_NONE. > > arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts > index 2ad3b09..34e2bce 100644 > --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts > +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts > @@ -101,6 +101,20 @@ > pinctrl-names = "default"; > pinctrl-0 = <&i2c2_pins_a>; > status = "okay"; > + > + gt911 at 5d { The node name should be the class of the device. touchscreen in this case. > + compatible = "goodix,gt911"; > + reg = <0x5d>; > + interrupt-parent = <&pio>; > + interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */ Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC bindings. You're also not adding a pinctrl group for that pin? > + }; > + > + gt911 at 14 { > + compatible = "goodix,gt911"; > + reg = <0x14>; > + interrupt-parent = <&pio>; > + interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */ > + }; And nodes should be ordered by addresses ascending order. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150331/a6c2adac/attachment.sig> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 2015-03-31 14:43 ` Maxime Ripard @ 2015-03-31 19:14 ` Aleksei Mamlin 2015-04-02 9:22 ` Maxime Ripard 2015-03-31 19:31 ` Aleksei Mamlin 1 sibling, 1 reply; 12+ messages in thread From: Aleksei Mamlin @ 2015-03-31 19:14 UTC (permalink / raw) To: linux-arm-kernel On Tue, 31 Mar 2015 07:43:38 -0700 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote: > > This patch adds nodes for the Goodix GT911 touchscreen controller found > > on the Wexler TAB7200 tablet. Controller uses one of following I2C > > addresses: 0x5d or 0x14, so just add two nodes. > > In which case are these different addresses encountered? Different > revisions of the same board? > According to the datasheet it is a feature of the controller. The address(0x5d or 0x14) can be configured using a reset sequence, which has not yet been implemented in the driver. > > > Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com> > > --- > > DT support for the Goodix GT911 touchscreen controller has been queued up > > by Dmitry Torokhov for merging into 4.1: > > https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next&id=771d8f1b178e7e09fcc641fccd48852958dbc329 > > > > IRQ flags are set by the touchscreen controller driver, so use IRQ_TYPE_NONE. > > > > arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts > > index 2ad3b09..34e2bce 100644 > > --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts > > +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts > > @@ -101,6 +101,20 @@ > > pinctrl-names = "default"; > > pinctrl-0 = <&i2c2_pins_a>; > > status = "okay"; > > + > > + gt911 at 5d { > > The node name should be the class of the device. touchscreen in this > case. > > > + compatible = "goodix,gt911"; > > + reg = <0x5d>; > > + interrupt-parent = <&pio>; > > + interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */ > > Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC > bindings. > > You're also not adding a pinctrl group for that pin? > > > + }; > > + > > + gt911 at 14 { > > + compatible = "goodix,gt911"; > > + reg = <0x14>; > > + interrupt-parent = <&pio>; > > + interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */ > > + }; > > And nodes should be ordered by addresses ascending order. > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- Thanks and regards, Aleksei Mamlin ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 2015-03-31 19:14 ` Aleksei Mamlin @ 2015-04-02 9:22 ` Maxime Ripard 2015-04-11 16:18 ` Aleksei Mamlin 0 siblings, 1 reply; 12+ messages in thread From: Maxime Ripard @ 2015-04-02 9:22 UTC (permalink / raw) To: linux-arm-kernel On Tue, Mar 31, 2015 at 10:14:20PM +0300, Aleksei Mamlin wrote: > On Tue, 31 Mar 2015 07:43:38 -0700 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > Hi, > > > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote: > > > This patch adds nodes for the Goodix GT911 touchscreen controller found > > > on the Wexler TAB7200 tablet. Controller uses one of following I2C > > > addresses: 0x5d or 0x14, so just add two nodes. > > > > In which case are these different addresses encountered? Different > > revisions of the same board? > > According to the datasheet it is a feature of the controller. > The address(0x5d or 0x14) can be configured using a reset sequence, > which has not yet been implemented in the driver. Which address is set up by the bootloader then? Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150402/4c8233b4/attachment.sig> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 2015-04-02 9:22 ` Maxime Ripard @ 2015-04-11 16:18 ` Aleksei Mamlin 2015-04-13 16:09 ` Maxime Ripard 0 siblings, 1 reply; 12+ messages in thread From: Aleksei Mamlin @ 2015-04-11 16:18 UTC (permalink / raw) To: linux-arm-kernel On Thu, 2 Apr 2015 11:22:59 +0200 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Tue, Mar 31, 2015 at 10:14:20PM +0300, Aleksei Mamlin wrote: > > On Tue, 31 Mar 2015 07:43:38 -0700 > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > > > Hi, > > > > > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote: > > > > This patch adds nodes for the Goodix GT911 touchscreen controller found > > > > on the Wexler TAB7200 tablet. Controller uses one of following I2C > > > > addresses: 0x5d or 0x14, so just add two nodes. > > > > > > In which case are these different addresses encountered? Different > > > revisions of the same board? > > > > According to the datasheet it is a feature of the controller. > > The address(0x5d or 0x14) can be configured using a reset sequence, > > which has not yet been implemented in the driver. > > Which address is set up by the bootloader then? > I assume that bootloader(u-boot) didn't sets up any address, but touchscreen controller usually uses 0x5d. Sometimes, after hard reset, it uses 0x14. For this we need nodes on both adresses. > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- Thanks and regards, Aleksei Mamlin ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 2015-04-11 16:18 ` Aleksei Mamlin @ 2015-04-13 16:09 ` Maxime Ripard 2015-04-13 19:01 ` Aleksei Mamlin 0 siblings, 1 reply; 12+ messages in thread From: Maxime Ripard @ 2015-04-13 16:09 UTC (permalink / raw) To: linux-arm-kernel On Sat, Apr 11, 2015 at 07:18:16PM +0300, Aleksei Mamlin wrote: > On Thu, 2 Apr 2015 11:22:59 +0200 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > On Tue, Mar 31, 2015 at 10:14:20PM +0300, Aleksei Mamlin wrote: > > > On Tue, 31 Mar 2015 07:43:38 -0700 > > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > > > > > Hi, > > > > > > > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote: > > > > > This patch adds nodes for the Goodix GT911 touchscreen controller found > > > > > on the Wexler TAB7200 tablet. Controller uses one of following I2C > > > > > addresses: 0x5d or 0x14, so just add two nodes. > > > > > > > > In which case are these different addresses encountered? Different > > > > revisions of the same board? > > > > > > According to the datasheet it is a feature of the controller. > > > The address(0x5d or 0x14) can be configured using a reset sequence, > > > which has not yet been implemented in the driver. > > > > Which address is set up by the bootloader then? > > I assume that bootloader(u-boot) didn't sets up any address, but touchscreen > controller usually uses 0x5d. Sometimes, after hard reset, it uses 0x14. > For this we need nodes on both adresses. I'm confused, who changes that address then? The controller itself? Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150413/94a5ec53/attachment.sig> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 2015-04-13 16:09 ` Maxime Ripard @ 2015-04-13 19:01 ` Aleksei Mamlin 2015-04-14 16:32 ` Maxime Ripard 0 siblings, 1 reply; 12+ messages in thread From: Aleksei Mamlin @ 2015-04-13 19:01 UTC (permalink / raw) To: linux-arm-kernel On Mon, 13 Apr 2015 18:09:51 +0200 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Sat, Apr 11, 2015 at 07:18:16PM +0300, Aleksei Mamlin wrote: > > On Thu, 2 Apr 2015 11:22:59 +0200 > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > > > On Tue, Mar 31, 2015 at 10:14:20PM +0300, Aleksei Mamlin wrote: > > > > On Tue, 31 Mar 2015 07:43:38 -0700 > > > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > > > > > > > Hi, > > > > > > > > > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote: > > > > > > This patch adds nodes for the Goodix GT911 touchscreen controller found > > > > > > on the Wexler TAB7200 tablet. Controller uses one of following I2C > > > > > > addresses: 0x5d or 0x14, so just add two nodes. > > > > > > > > > > In which case are these different addresses encountered? Different > > > > > revisions of the same board? > > > > > > > > According to the datasheet it is a feature of the controller. > > > > The address(0x5d or 0x14) can be configured using a reset sequence, > > > > which has not yet been implemented in the driver. > > > > > > Which address is set up by the bootloader then? > > > > I assume that bootloader(u-boot) didn't sets up any address, but touchscreen > > controller usually uses 0x5d. Sometimes, after hard reset, it uses 0x14. > > For this we need nodes on both adresses. > > I'm confused, who changes that address then? > > The controller itself? > If I understood correctly, when device starts it sets reset pin (PB13) to high level and int pin(PH21) to low level. After this int pin sets up as external interrupt. This sequence triggers controller to use 0x5d address. After hard reset both pins may be hight level and it triggers controller to use 0x14 address. Please see datasheets at pages 8-10. https://drive.google.com/file/d/0BxCVOQS3ZymGdEE0cHI3bnp5WVE https://drive.google.com/file/d/0BxCVOQS3ZymGbDAzVnZwZ2lOZ1E > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- Thanks and regards, Aleksei Mamlin ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 2015-04-13 19:01 ` Aleksei Mamlin @ 2015-04-14 16:32 ` Maxime Ripard 0 siblings, 0 replies; 12+ messages in thread From: Maxime Ripard @ 2015-04-14 16:32 UTC (permalink / raw) To: linux-arm-kernel On Mon, Apr 13, 2015 at 10:01:00PM +0300, Aleksei Mamlin wrote: > On Mon, 13 Apr 2015 18:09:51 +0200 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > On Sat, Apr 11, 2015 at 07:18:16PM +0300, Aleksei Mamlin wrote: > > > On Thu, 2 Apr 2015 11:22:59 +0200 > > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > > > > > On Tue, Mar 31, 2015 at 10:14:20PM +0300, Aleksei Mamlin wrote: > > > > > On Tue, 31 Mar 2015 07:43:38 -0700 > > > > > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote: > > > > > > > This patch adds nodes for the Goodix GT911 touchscreen controller found > > > > > > > on the Wexler TAB7200 tablet. Controller uses one of following I2C > > > > > > > addresses: 0x5d or 0x14, so just add two nodes. > > > > > > > > > > > > In which case are these different addresses encountered? Different > > > > > > revisions of the same board? > > > > > > > > > > According to the datasheet it is a feature of the controller. > > > > > The address(0x5d or 0x14) can be configured using a reset sequence, > > > > > which has not yet been implemented in the driver. > > > > > > > > Which address is set up by the bootloader then? > > > > > > I assume that bootloader(u-boot) didn't sets up any address, but touchscreen > > > controller usually uses 0x5d. Sometimes, after hard reset, it uses 0x14. > > > For this we need nodes on both adresses. > > > > I'm confused, who changes that address then? > > > > The controller itself? > > > If I understood correctly, when device starts it sets reset pin (PB13) to > high level and int pin(PH21) to low level. After this int pin sets up as > external interrupt. This sequence triggers controller to use 0x5d address. > > After hard reset both pins may be hight level and it triggers controller > to use 0x14 address. > > Please see datasheets at pages 8-10. > > https://drive.google.com/file/d/0BxCVOQS3ZymGdEE0cHI3bnp5WVE > https://drive.google.com/file/d/0BxCVOQS3ZymGbDAzVnZwZ2lOZ1E If so, then the driver should be fixed to handle that power sequence correctly and make sure that the device is using the 0x5d address, whatever the previous state was. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150414/84b59097/attachment.sig> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 2015-03-31 14:43 ` Maxime Ripard 2015-03-31 19:14 ` Aleksei Mamlin @ 2015-03-31 19:31 ` Aleksei Mamlin 2015-04-02 18:50 ` Maxime Ripard 1 sibling, 1 reply; 12+ messages in thread From: Aleksei Mamlin @ 2015-03-31 19:31 UTC (permalink / raw) To: linux-arm-kernel On Tue, 31 Mar 2015 07:43:38 -0700 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Tue, Mar 31, 2015 at 11:18:17AM +0300, Aleksei Mamlin wrote: > > This patch adds nodes for the Goodix GT911 touchscreen controller found > > on the Wexler TAB7200 tablet. Controller uses one of following I2C > > addresses: 0x5d or 0x14, so just add two nodes. > > In which case are these different addresses encountered? Different > revisions of the same board? > > > Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com> > > --- > > DT support for the Goodix GT911 touchscreen controller has been queued up > > by Dmitry Torokhov for merging into 4.1: > > https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?h=next&id=771d8f1b178e7e09fcc641fccd48852958dbc329 > > > > IRQ flags are set by the touchscreen controller driver, so use IRQ_TYPE_NONE. > > > > arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts > > index 2ad3b09..34e2bce 100644 > > --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts > > +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts > > @@ -101,6 +101,20 @@ > > pinctrl-names = "default"; > > pinctrl-0 = <&i2c2_pins_a>; > > status = "okay"; > > + > > + gt911 at 5d { > > The node name should be the class of the device. touchscreen in this > case. > Ok, I'll fix it. > > > + compatible = "goodix,gt911"; > > + reg = <0x5d>; > > + interrupt-parent = <&pio>; > > + interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */ > > Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC > bindings. > Hmm. Which value I must use in this case? IRQ type is set by the touchscreen controller driver, so I think that value must be 0. > > You're also not adding a pinctrl group for that pin? > No, because it works fine with this DT nodes. It seems that I should first configure pin to work in interrupt mode. Correct? > > > + }; > > + > > + gt911 at 14 { > > + compatible = "goodix,gt911"; > > + reg = <0x14>; > > + interrupt-parent = <&pio>; > > + interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */ > > + }; > > And nodes should be ordered by addresses ascending order. > I'll fix it too. > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- Thanks and regards, Aleksei Mamlin ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 2015-03-31 19:31 ` Aleksei Mamlin @ 2015-04-02 18:50 ` Maxime Ripard 2015-04-11 16:36 ` Aleksei Mamlin 0 siblings, 1 reply; 12+ messages in thread From: Maxime Ripard @ 2015-04-02 18:50 UTC (permalink / raw) To: linux-arm-kernel On Tue, Mar 31, 2015 at 10:31:20PM +0300, Aleksei Mamlin wrote: > > > + compatible = "goodix,gt911"; > > > + reg = <0x5d>; > > > + interrupt-parent = <&pio>; > > > + interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */ > > > > Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC > > bindings. > > > > Hmm. Which value I must use in this case? IRQ type is set by the > touchscreen controller driver, so I think that value must be 0. Whatever the hardware is using. Presumably the same value than the driver sets. > > > > You're also not adding a pinctrl group for that pin? > > No, because it works fine with this DT nodes. It seems that I should > first configure pin to work in interrupt mode. Correct? You don't have to, since the pio driver will already take care of muxing it to the right function, but that will prevent any driver to call pinctrl_request on the same pin. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150402/26232ff0/attachment.sig> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 2015-04-02 18:50 ` Maxime Ripard @ 2015-04-11 16:36 ` Aleksei Mamlin 2015-04-13 15:59 ` Maxime Ripard 0 siblings, 1 reply; 12+ messages in thread From: Aleksei Mamlin @ 2015-04-11 16:36 UTC (permalink / raw) To: linux-arm-kernel On Thu, 2 Apr 2015 20:50:08 +0200 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Tue, Mar 31, 2015 at 10:31:20PM +0300, Aleksei Mamlin wrote: > > > > + compatible = "goodix,gt911"; > > > > + reg = <0x5d>; > > > > + interrupt-parent = <&pio>; > > > > + interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */ > > > > > > Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC > > > bindings. > > > > > > > Hmm. Which value I must use in this case? IRQ type is set by the > > touchscreen controller driver, so I think that value must be 0. > > Whatever the hardware is using. Presumably the same value than the > driver sets. > > > > > > > You're also not adding a pinctrl group for that pin? > > > > No, because it works fine with this DT nodes. It seems that I should > > first configure pin to work in interrupt mode. Correct? > > You don't have to, since the pio driver will already take care of > muxing it to the right function, but that will prevent any driver to > call pinctrl_request on the same pin. > It is still necessary? I see that you have accepted Hans de Goede's patches: http://www.spinics.net/lists/arm-kernel/msg411142.html > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- Thanks and regards, Aleksei Mamlin ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 2015-04-11 16:36 ` Aleksei Mamlin @ 2015-04-13 15:59 ` Maxime Ripard 0 siblings, 0 replies; 12+ messages in thread From: Maxime Ripard @ 2015-04-13 15:59 UTC (permalink / raw) To: linux-arm-kernel On Sat, Apr 11, 2015 at 07:36:14PM +0300, Aleksei Mamlin wrote: > On Thu, 2 Apr 2015 20:50:08 +0200 > Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > > > On Tue, Mar 31, 2015 at 10:31:20PM +0300, Aleksei Mamlin wrote: > > > > > + compatible = "goodix,gt911"; > > > > > + reg = <0x5d>; > > > > > + interrupt-parent = <&pio>; > > > > > + interrupts = <21 IRQ_TYPE_NONE>; /* EINT21 (PH21) */ > > > > > > > > Unfortunately, IRQ_TYPE_NONE is not a valid value for the GIC > > > > bindings. > > > > > > > > > > Hmm. Which value I must use in this case? IRQ type is set by the > > > touchscreen controller driver, so I think that value must be 0. > > > > Whatever the hardware is using. Presumably the same value than the > > driver sets. > > > > > > > > > > You're also not adding a pinctrl group for that pin? > > > > > > No, because it works fine with this DT nodes. It seems that I should > > > first configure pin to work in interrupt mode. Correct? > > > > You don't have to, since the pio driver will already take care of > > muxing it to the right function, but that will prevent any driver to > > call pinctrl_request on the same pin. > > It is still necessary? > I see that you have accepted Hans de Goede's patches: http://www.spinics.net/lists/arm-kernel/msg411142.html No, it's fine. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150413/568ef726/attachment-0001.sig> ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2015-04-14 16:32 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-03-31 8:18 [PATCH] ARM: dts: sun7i: Add Goodix GT911 nodes for Wexler TAB7200 Aleksei Mamlin 2015-03-31 14:43 ` Maxime Ripard 2015-03-31 19:14 ` Aleksei Mamlin 2015-04-02 9:22 ` Maxime Ripard 2015-04-11 16:18 ` Aleksei Mamlin 2015-04-13 16:09 ` Maxime Ripard 2015-04-13 19:01 ` Aleksei Mamlin 2015-04-14 16:32 ` Maxime Ripard 2015-03-31 19:31 ` Aleksei Mamlin 2015-04-02 18:50 ` Maxime Ripard 2015-04-11 16:36 ` Aleksei Mamlin 2015-04-13 15:59 ` Maxime Ripard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).