Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] doc/bindings: Update PCIe devicetree binding documentation for LS2085A
Date: Wed, 1 Apr 2015 12:48:32 +0100	[thread overview]
Message-ID: <20150401114832.GD11403@leverpostej> (raw)
In-Reply-To: <1427888463-29549-3-git-send-email-bhupesh.sharma@freescale.com>

Hi,

On Wed, Apr 01, 2015 at 12:40:56PM +0100, Bhupesh Sharma wrote:
> Add the documentation for compatible string "fsl,ls2085a-pcie"
> for LS2085A platform.
> 
> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>

[...]

> Change-Id: I0d51607e86544be8906c996c08a2b2b558243bd4
> Reviewed-on: http://git.am.freescale.net:8181/28740
> Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com>

These three are meaningless here. Please drop them.

> Reviewed-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
> Tested-by: Bhupesh Sharma <bhupesh.sharma@freescale.com>
> ---
>  .../devicetree/bindings/pci/layerscape-pci.txt     |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> index 6286f04..0654809 100644
> --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> @@ -4,7 +4,8 @@ This PCIe host controller is based on the Synopsis Designware PCIe IP
>  and thus inherits all the common properties defined in designware-pcie.txt.
>  
>  Required properties:
> -- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie"
> +- compatible: should contain the platform identifier such as "fsl,ls1021a-pcie",
> +  "fsl,ls2085a-pcie".

Please format this as a list, e.g.

- compatible: schould contain one of:
  * "fsl,ls1021a-pcie"
  * "fsl,ls2085a-pcie"

Is the ls2085a PCIe controller significantly different from that of
ls1021a? Is "fsl,ls1021a-pcie" valid as a fallback entry?

Mark.

>  - reg: base addresses and lengths of the PCIe controller
>  - interrupts: A list of interrupt outputs of the controller. Must contain an
>    entry for each entry in the interrupt-names property.
> -- 
> 1.7.9.5
> 
> 

  reply	other threads:[~2015-04-01 11:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 11:40 [PATCH 0/8] ARM64: Update support for FSL's LS2085A SoC Bhupesh Sharma
2015-04-01 11:40 ` [PATCH 1/8] Documentation: DT: Add entry for FSL LS2085A QDS and RDB boards Bhupesh Sharma
2015-04-01 11:40 ` [PATCH 2/8] doc/bindings: Update PCIe devicetree binding documentation for LS2085A Bhupesh Sharma
2015-04-01 11:48   ` Mark Rutland [this message]
2015-04-01 11:52     ` bhupesh.sharma at freescale.com
2015-04-21  5:06       ` Minghuan.Lian at freescale.com
2015-04-01 11:40 ` [PATCH 3/8] doc/bindings: Update clk-qoriq bindings for FSL's chassis-3.0 SoCs Bhupesh Sharma
2015-04-01 11:40 ` [PATCH 4/8] layerscape/ftm: Add compatible string for FTM0 be used as alarm timer Bhupesh Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150401114832.GD11403@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox