linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mvebu: use 0xf1000000 as internal registers on Armada 370 DB
Date: Thu, 2 Apr 2015 17:02:53 +0200	[thread overview]
Message-ID: <20150402170253.70e951bd@free-electrons.com> (raw)
In-Reply-To: <20150402144823.GJ24899@n2100.arm.linux.org.uk>

Dear Russell King - ARM Linux,

On Thu, 2 Apr 2015 15:48:24 +0100, Russell King - ARM Linux wrote:

> Wrong.  It's Arnd's responsibility to make sure that platform maintainers
> don't do stupid things like change the DT in incompatible ways which
> break lots of people's setups.
> 
> However, it is _your_ responsibility as the platform maintainer to place

I am _not_ a platform maintainer. But thanks for supposing so :-)

> sufficient information into the commit message that explains why the
> change is necessary, and justifies the change.  Much of what you've said
> in these follow-on emails should have been in the original message to
> explain what the situation is, and why the change is appropriate.
> 
> I'm willing to bet that if the commit description had explained it
> properly, Arnd would have applied it by now.

Agreed that the commit message could have been better. Though the
commit message is sufficiently clear for the platform maintainers to
understand, since they have all the background about the platform
needed to understand it. I don't think all commit messages in the
kernel are meant to be understood by developers having no knowledge of
the area touched by the patch.

My commit log has way enough details for the platform maintainers
Andrew Lunn, Jason Cooper, Gregory Clement and Sebastian Hesselbarth to
make up their mind about the patch.

See the reaction from both Andrew and Jason: they understood the patch
and basically agree with it.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-04-02 15:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02  9:16 [PATCH] ARM: mvebu: use 0xf1000000 as internal registers on Armada 370 DB Thomas Petazzoni
2015-04-02 13:28 ` Arnd Bergmann
2015-04-02 13:35   ` Andrew Lunn
2015-04-02 13:36   ` Thomas Petazzoni
2015-04-02 14:09     ` Arnd Bergmann
2015-04-02 14:16       ` Thomas Petazzoni
2015-04-02 14:48         ` Russell King - ARM Linux
2015-04-02 15:02           ` Thomas Petazzoni [this message]
2015-04-02 15:25             ` Russell King - ARM Linux
2015-04-02 14:48         ` Jason Cooper
2015-04-02 15:35         ` Gregory CLEMENT
2015-04-02 15:33           ` Andrew Lunn
2015-04-03  7:49             ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150402170253.70e951bd@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).