linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: Two new breakages since Thursday
Date: Sat, 11 Apr 2015 10:00:24 +0100	[thread overview]
Message-ID: <20150411090024.GL12732@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150405080645.GE13898@n2100.arm.linux.org.uk>

And almost a week later, and most of these are _still_ present.

Given that the merge window is potentially opening on Sunday, this
is _very_ poor, because it means that we've had a week of failing
builds in the week before the merge window - the week where we
_should_ be stabilising the code and getting it ready for submission
to Linus.

Right now, arm-soc is *NOT* ready for submission to Linus.

Please fix this as a top priority.

On Sun, Apr 05, 2015 at 09:06:45AM +0100, Russell King - ARM Linux wrote:
> Two new breakages have appeared since Thursday.  The first affects both
> ARM and ARM64 builds (a missing file), the second only ARM builds.
> 
> arch/arm64/boot/dts/mediatek/mt8173-pinfunc.h:18:40: fatal error: dt-bindings/pinctrl/mt65xx.h: No such file or directory
> arch/arm/boot/dts/mt8135-pinfunc.h:18:40: fatal error: dt-bindings/pinctrl/mt65xx.h: No such file or directory
> arch/arm/mach-at91/pm_suspend.S:143: Error: selected processor does not support ARM mode `dsb'
> 
> ARM64 breaks on a defconfig build, ARM breaks with these errors on
> an allmodconfig build.
> 
> The first two are due to the mediatek patches merged via the arm-soc
> tree.  The second is due to:
> 
> commit 20567658b8f010eea287087bfdbeb25757801aed
> Author: Wenyou Yang <wenyou.yang@atmel.com>
> Date:   Mon Mar 9 11:53:46 2015 +0800
> 
>     ARM: at91/pm_suspend: add the WFI instruction support for ARMv7
> 
> which looks to me like completely the wrong solution:
> 
> +       .macro at91_cpu_idle
> +
> +#if defined(CONFIG_CPU_V7)
> +       mov     tmp1, #AT91_PMC_PCK
> +       str     tmp1, [pmc, #AT91_PMC_SCDR]
> +
> +       dsb
> +
> +       wfi             @ Wait For Interrupt
> +#else
> +       mcr     p15, 0, tmp1, c7, c0, 4
> +#endif
> +
> +       .endm
> 
> So, if we build a kernel with ARMc6 and ARMv7 CPUs, AT91 ends up using
> ARMv7-only instructions in this function, which will cause an illegal
> instruction exception on ARMv6 CPUs.
> 
> -- 
> FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
> according to speedtest.net.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

  parent reply	other threads:[~2015-04-11  9:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-05  8:06 Two new breakages since Thursday Russell King - ARM Linux
2015-04-05 10:12 ` Alexandre Belloni
2015-04-05 19:50   ` Nicolas Ferre
2015-04-11  9:00 ` Russell King - ARM Linux [this message]
2015-04-13 16:18   ` Yingjoe Chen
2015-04-13 22:41     ` Arnd Bergmann
2015-04-14  9:26       ` Russell King - ARM Linux
2015-04-14  9:34         ` Arnd Bergmann
2015-04-14 14:28           ` Tony Lindgren
2015-04-14 14:59             ` Arnd Bergmann
2015-04-14 15:05               ` Tony Lindgren
2015-04-14 16:21                 ` Tony Lindgren
2015-04-15 19:50                   ` Arnd Bergmann
2015-04-15 20:00                     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150411090024.GL12732@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).