From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Mon, 13 Apr 2015 13:41:22 +0100 Subject: [PATCH V2] drivers: CCI: fix used_mask init in validate_group() In-Reply-To: <20150409153629.GI9648@leverpostej> References: <20150409144029.GE9648@leverpostej> <1428591425-17330-1-git-send-email-msalter@redhat.com> <20150409153629.GI9648@leverpostej> Message-ID: <20150413124121.GF2869@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Apr 09, 2015 at 04:36:29PM +0100, Mark Rutland wrote: > On Thu, Apr 09, 2015 at 03:57:05PM +0100, Mark Salter wrote: > > Currently in validate_group(), there is a static initializer > > for fake_pmu.used_mask which is based on CPU_BITS_NONE but > > the used_mask array size is based on CCI_PMU_MAX_HW_EVENTS. > > CCI_PMU_MAX_HW_EVENTS is not based on NR_CPUS, so CPU_BITS_NONE > > is not correct and will cause a build failure if NR_CPUS > > is set high enough to make CPU_BITS_NONE larger than used_mask. > > > > Signed-off-by: Mark Salter > > Reviewed-by: Mark Rutland > > Arnd, Olof, are you happy to take this via arm-soc? > > My (broken) patch went via Will's tree because of a perf dependency, but > other CCI patches have gone via you guys. Yeah, arm-soc is the best place for this. You should resend to arm at kernel.org as a new patch with the relevant acks. Will