From mboxrd@z Thu Jan  1 00:00:00 1970
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
Date: Sat, 18 Apr 2015 10:57:12 +0200
Subject: [RFC PATCH 1/2] tee: generic TEE subsystem
In-Reply-To: <1429257057-7935-2-git-send-email-jens.wiklander@linaro.org>
References: <1429257057-7935-1-git-send-email-jens.wiklander@linaro.org>
 <1429257057-7935-2-git-send-email-jens.wiklander@linaro.org>
Message-ID: <20150418085712.GB29858@kroah.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote:
> +struct tee_device {
> +	char name[TEE_MAX_DEV_NAME_LEN];
> +	const struct tee_desc *desc;
> +	struct device *dev;

No, please embed the device in your structure, don't have a pointer to
it.

> +	struct miscdevice miscdev;

This can be a pointer, as the lifecycle of your device is not dictated
by the miscdevice, but rather the 'struct device'.

> +
> +	void *driver_data;

You don't need this, use 'struct device''s pointer instead.

> +
> +	struct list_head list_shm;
> +	struct tee_shm_pool *pool;
> +};