From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mm: add imprecise abort non-deadly handler
Date: Sat, 18 Apr 2015 10:08:45 +0100 [thread overview]
Message-ID: <20150418090845.GH12732@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1429316083.8341.76.camel@xylophone.i.decadent.org.uk>
On Sat, Apr 18, 2015 at 01:14:43AM +0100, Ben Hutchings wrote:
> From: Ben Dooks <ben.dooks@codethink.co.uk>
>
> Given that imprecise aborts may be delivered after the action that
> caused them (or even for non-cpu related activities such as bridge
> faults from a bus-master) it is possible that the wrong process is
> terminated as a result.
>
> Add a handler to take and print imprecise aborts and allow the process
> to continue. This should ensure that the abort is shown but not kill
> the process that was running on the cpu core at the time.
I'm not happy with this.
On older CPUs, you generally get the "imprecise" (aka external) aborts
within a few cycles of the faulting instruction, which is good enough
to ensure that the appropriate process gets terminated.
Yes, this is not true of ARMv7, where such faults can happen a longer
time after the access which caused them.
However, I would argue that merely printing a message to the kernel
log is insufficient - especially as the kernel networking layer can
spam the log so that such messages yet rotated out of the ring buffer.
An imprecise abort is a serious condition, one which _ought_ to be very
noticable, on the level of panic()ing the kernel. It's a data loss
condition, one which _can_ result in corruption of user data or even
filesystems.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-04-18 9:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 0:14 [PATCH] ARM: mm: add imprecise abort non-deadly handler Ben Hutchings
2015-04-18 9:08 ` Russell King - ARM Linux [this message]
2015-04-20 8:57 ` Ben Hutchings
-- strict thread matches above, loose matches on Subject: below --
2014-02-07 18:20 imprecise abort behaviour Ben Dooks
2014-02-07 18:20 ` [PATCH] ARM: mm: add imprecise abort non-deadly handler Ben Dooks
2014-02-10 14:37 ` Dave Martin
2014-02-10 17:25 ` Ben Dooks
2014-02-11 15:43 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150418090845.GH12732@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).