From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: perf: don't warn about missing interrupt-affinity property for PPIs
Date: Thu, 23 Apr 2015 15:02:24 +0100 [thread overview]
Message-ID: <20150423140223.GI1652@arm.com> (raw)
In-Reply-To: <20150423140058.GF29702@leverpostej>
On Thu, Apr 23, 2015 at 03:01:00PM +0100, Mark Rutland wrote:
> On Thu, Apr 23, 2015 at 02:50:30PM +0100, Will Deacon wrote:
> > PPIs are affine by nature, so the interrupt-affinity property is not
> > used and therefore we shouldn't print a warning in its absence.
> >
> > Reported-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > ---
> > arch/arm/kernel/perf_event_cpu.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/kernel/perf_event_cpu.c b/arch/arm/kernel/perf_event_cpu.c
> > index 91c7ba182dcd..becf7ad6eddc 100644
> > --- a/arch/arm/kernel/perf_event_cpu.c
> > +++ b/arch/arm/kernel/perf_event_cpu.c
> > @@ -303,12 +303,17 @@ static int probe_current_pmu(struct arm_pmu *pmu)
> >
> > static int of_pmu_irq_cfg(struct platform_device *pdev)
> > {
> > - int i;
> > + int i, irq;
> > int *irqs = kcalloc(pdev->num_resources, sizeof(*irqs), GFP_KERNEL);
> >
> > if (!irqs)
> > return -ENOMEM;
> >
> > + /* Don't bother with PPIs; they're already affine */
> > + irq = platform_get_irq(pdev, 0);
> > + if (irq >= 0 && irq_is_percpu(irq))
> > + return 0;
>
> Is 0 still a valid IRQ on any ARM platforms?
I just went for consistency with the cpu_pmu_{request,free}_irq paths.
Will
next prev parent reply other threads:[~2015-04-23 14:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 13:50 [PATCH 1/4] ARM: perf: don't warn about missing interrupt-affinity property for PPIs Will Deacon
2015-04-23 13:50 ` [PATCH 2/4] ARM perf: Fix the pmu node name in warning message Will Deacon
2015-04-23 13:58 ` Mark Rutland
2015-05-01 13:59 ` Sudeep Holla
2015-05-01 14:07 ` Will Deacon
2015-05-01 14:07 ` Mark Rutland
2015-05-01 14:20 ` Sudeep Holla
2015-04-23 13:50 ` [PATCH 3/4] arm64: perf: don't warn about missing interrupt-affinity property for PPIs Will Deacon
2015-04-23 13:50 ` [PATCH 4/4] arm64: perf: Fix the pmu node name in warning message Will Deacon
2015-04-23 14:01 ` [PATCH 1/4] ARM: perf: don't warn about missing interrupt-affinity property for PPIs Mark Rutland
2015-04-23 14:02 ` Will Deacon [this message]
2015-04-23 14:11 ` Mark Rutland
2015-04-23 15:56 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150423140223.GI1652@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).