linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: omap: Allow building as a loadable module
Date: Fri, 24 Apr 2015 09:22:47 -0700	[thread overview]
Message-ID: <20150424162247.GT18048@atomide.com> (raw)
In-Reply-To: <20150424161127.GG5692@saruman.tx.rr.com>

* Felipe Balbi <balbi@ti.com> [150424 09:14]:
> On Thu, Apr 23, 2015 at 04:56:22PM -0700, Tony Lindgren wrote:
> > We currently get all kinds of errors building the omap gpio driver
> > as a module starting with:
> > 
> > undefined reference to `omap2_gpio_resume_after_idle'
> > undefined reference to `omap2_gpio_prepare_for_idle'
> > ...
> > 
> > Let's fix the issue by adding inline functions to the header.
> > Note that we can now also remove the two unused functions for
> > omap_set_gpio_debounce and omap_set_gpio_debounce_time.
> > 
> > Then doing rmmod on the module produces further warnings
> > because of missing exit related functions. Let's add those.
> > 
> > And finally, we can make the Kconfig entry just a tristate
> > option that's selected for omaps.
> > 
> > Cc: Felipe Balbi <balbi@ti.com>
> > Cc: Javier Martinez Canillas <javier@dowhile0.org>
> > Cc: Grygorii Strashko <grygorii.strashko@linaro.org>
> > Cc: Kevin Hilman <khilman@deeprootsystems.com>
> > Cc: Nishanth Menon <nm@ti.com>
> > Cc: Santosh Shilimkar <ssantosh@kernel.org>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> Just to be clear: when GPIO is a module, we can't really idle, can we ?

Right we cannot do off idle because of the context loss
until we have some way to register driver specific idle
functions.

Regards,

Tony

  reply	other threads:[~2015-04-24 16:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 23:56 [PATCH] gpio: omap: Allow building as a loadable module Tony Lindgren
2015-04-24 14:59 ` Grygorii.Strashko@linaro.org
2015-04-24 15:40 ` santosh shilimkar
2015-04-24 16:11 ` Felipe Balbi
2015-04-24 16:22   ` Tony Lindgren [this message]
2015-05-06 13:23 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150424162247.GT18048@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).