From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Sun, 26 Apr 2015 10:42:21 +0200 Subject: [PATCH 3/3] ARM: sunxi: spi: use proper errno when message is too long. In-Reply-To: <4c27d44b2bdd759424ce4a4b2e8f6abf5d5a6735.1430034797.git.hramrach@gmail.com> References: <4c27d44b2bdd759424ce4a4b2e8f6abf5d5a6735.1430034797.git.hramrach@gmail.com> Message-ID: <20150426084221.GE5627@lukather> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Apr 25, 2015 at 09:21:07PM +0200, Michal Suchanek wrote: > Signed-off-by: Michal Suchanek No commit log? > --- > drivers/spi/spi-sun4i.c | 2 +- > drivers/spi/spi-sun6i.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c > index fbb0a4d..8238b4e 100644 > --- a/drivers/spi/spi-sun4i.c > +++ b/drivers/spi/spi-sun4i.c > @@ -176,7 +176,7 @@ static int sun4i_spi_transfer_one(struct spi_master *master, > > /* We don't support transfer larger than the FIFO */ > if (tfr->len > SUN4I_FIFO_DEPTH) > - return -EINVAL; > + return -EMSGSIZE; Is it still a thing? The patch to remove such limit hasn't been merged yet? > reinit_completion(&sspi->done); > sspi->tx_buf = tfr->tx_buf; > diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c > index ac48f59..0f5dd91 100644 > --- a/drivers/spi/spi-sun6i.c > +++ b/drivers/spi/spi-sun6i.c > @@ -166,7 +166,7 @@ static int sun6i_spi_transfer_one(struct spi_master *master, > > /* We don't support transfer larger than the FIFO */ > if (tfr->len > SUN6I_FIFO_DEPTH) > - return -EINVAL; > + return -EMSGSIZE; Eventually, we should move to using DMA for these messages longer than the FIFO. I should post these patches. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: