From mboxrd@z Thu Jan 1 00:00:00 1970 From: baruch@tkos.co.il (Baruch Siach) Date: Wed, 29 Apr 2015 18:25:27 +0300 Subject: [PATCH 1/1] ARM: imx: make the imx timer driver implementation independent of SoCs. In-Reply-To: References: <1430316881-4668-1-git-send-email-shenwei.wang@freescale.com> <20150429142614.GE2258@tarshish> <20150429150824.GF2258@tarshish> Message-ID: <20150429152527.GH2258@tarshish> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Shenwei Wang, On Wed, Apr 29, 2015 at 03:19:19PM +0000, Shenwei Wang wrote: > > -----Original Message----- > > From: Baruch Siach [mailto:baruch at tkos.co.il] > > Sent: 2015?4?29? 10:08 > > To: Wang Shenwei-B38339 > > Cc: shawn.guo at linaro.org; linux-arm-kernel at lists.infradead.org; > > devicetree at vger.kernel.org > > Subject: Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation > > independent of SoCs. > > > > When several SoC share the same IP block the usual convention is to name > > it in > > the compatible property string after the first SoC it appeared on. Just look at > > some binding documentation from Documentation/devicetree/bindings/timer/ to > > find examples. The allwinner,sun5i-a13-hstimer property is shared by A10s and > > A13 SoCs. The amlogic,meson6-timer is shared by Meson6 and Meson8 SoCs, and > > so on. > > If the same IP block is shared with several SoCs, why we gave them different compatible > strings? If no changes in an IP block, I assume no changes in the relating driver as well. > In this assumption, I don't see any need to introduce a new compatible string for an > unchanged IP block in a new SoC. That is exactly what I meant to say. Sorry that I was not clear enough. When the same IP block is used in a newer generation SoC the same compatible property string is used. For that reason you can find in sun5i-a10s.dtsi the line compatible = "allwinner,sun5i-a13-hstimer"; baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -