linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/2] clk: improve handling of orphan clocks
Date: Thu, 30 Apr 2015 17:19:01 -0700	[thread overview]
Message-ID: <20150501001901.GC32407@codeaurora.org> (raw)
In-Reply-To: <1429735986-18592-1-git-send-email-heiko@sntech.de>

On 04/22, Heiko Stuebner wrote:
> Using orphan clocks can introduce strange behaviour as they don't have
> rate information at all and also of course don't track 
> 
> This v2/v3 takes into account suggestions from Stephen Boyd to not try to
> walk the clock tree at runtime but instead keep track of orphan states
> on clock tree changes and making it mandatory for everybody from the
> start as orphaned clocks should not be used at all.
> 
> 
> This fixes an issue on most rk3288 platforms, where some soc-clocks
> are supplied by a 32khz clock from an external i2c-chip which often
> is only probed later in the boot process and maybe even after the
> drivers using these soc-clocks like the tsadc temperature sensor.
> In this case the driver using the clock should of course defer probing
> until the clock is actually usable.
> 
> 
> As this changes the behaviour for orphan clocks, it would of course
> benefit from more testing than on my Rockchip boards. To keep the
> recipent-list reasonable and not spam to much I selected one (the topmost)
> from the get_maintainer output of each drivers/clk entry.
> Hopefully some will provide Tested-by-tags :-)
> 

<grumble> I don't see any Tested-by: tags yet </grumble>. I've
put these two patches on a separate branch "defer-orphans" and
pushed it to clk-next so we can give it some more exposure.

Unfortunately this doesn't solve the orphan problem for non-OF
providers. What if we did the orphan check in __clk_create_clk()
instead and returned an error pointer for orphans? I suspect that
will solve all cases, right?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  parent reply	other threads:[~2015-05-01  0:19 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-22 20:53 [PATCH v3 0/2] clk: improve handling of orphan clocks Heiko Stuebner
2015-04-22 20:53 ` [PATCH v3 1/2] clk: track the orphan status of clocks and their children Heiko Stuebner
2015-04-30 23:20   ` Stephen Boyd
2015-04-22 20:53 ` [PATCH v3 2/2] clk: prevent orphan clocks from being used Heiko Stuebner
2015-04-30 23:20   ` Stephen Boyd
2015-04-25 12:23 ` [PATCH v3 0/2] clk: improve handling of orphan clocks Stefan Wahren
2015-04-25 13:44   ` Heiko Stübner
2015-04-26 19:58 ` Robert Jarzmik
2015-05-01  0:19 ` Stephen Boyd [this message]
2015-05-01 19:59   ` Heiko Stübner
2015-05-01 20:52     ` Stephen Boyd
2015-05-01 22:07       ` Heiko Stübner
2015-05-01 23:40         ` Stephen Boyd
2015-05-07  8:22           ` Tero Kristo
2015-05-07 18:18             ` Stephen Boyd
2015-05-08 11:41               ` Tero Kristo
2015-05-07 15:17           ` Kevin Hilman
2015-05-07 21:03             ` Stephen Boyd
2015-05-08  0:27               ` Kevin Hilman
2015-05-08  6:53                 ` Stephen Boyd
2015-05-08  8:13                   ` Sascha Hauer
2015-05-08  9:30                     ` Heiko Stübner
2015-05-08  9:53                       ` Sascha Hauer
2015-05-08 10:02               ` Maxime Ripard
2015-05-12 22:35                 ` Stephen Boyd
2015-05-13 13:03                   ` Maxime Ripard
2015-05-13 14:33                     ` Kevin Hilman
2015-05-13 20:14                       ` Maxime Ripard
2015-05-13 20:44                         ` Kevin Hilman
2015-05-13 20:51                           ` Maxime Ripard
2015-07-27  8:57                 ` Heiko Stübner
2015-07-30 10:09                   ` Maxime Ripard
2015-08-11 22:34                     ` Stephen Boyd
2015-08-12  8:26                       ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150501001901.GC32407@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).