From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.hauer@pengutronix.de (Sascha Hauer) Date: Mon, 4 May 2015 16:31:05 +0200 Subject: [PATCH 6/7] ARM: dts: mt8135: enable basic SMP bringup for mt8135 In-Reply-To: <1430466210-22963-7-git-send-email-yingjoe.chen@mediatek.com> References: <1430466210-22963-1-git-send-email-yingjoe.chen@mediatek.com> <1430466210-22963-7-git-send-email-yingjoe.chen@mediatek.com> Message-ID: <20150504143105.GK4946@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, May 01, 2015 at 03:43:29PM +0800, Yingjoe Chen wrote: > Add arch timer node to enable arch-timer support. MT8135 firmware > doesn't correctly setup arch-timer frequency and CNTVOFF, add > properties to workaround this. > > This also set cpu enable-method to enable SMP. > > Signed-off-by: Yingjoe Chen > --- > arch/arm/boot/dts/mt8135.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi > index 612bd22..eb5e06f 100644 > --- a/arch/arm/boot/dts/mt8135.dtsi > +++ b/arch/arm/boot/dts/mt8135.dtsi > @@ -46,6 +46,7 @@ > cpus { > #address-cells = <1>; > #size-cells = <0>; > + enable-method = "mediatek,mt81xx-tz-smp"; > > cpu0: cpu at 0 { > device_type = "cpu"; > @@ -103,6 +104,21 @@ > }; > }; > > + timer { > + compatible = "arm,armv7-timer"; > + interrupt-parent = <&gic>; > + interrupts = + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>; > + clock-frequency = <13000000>; > + arm,cpu-registers-not-fw-configured; > + }; This is the SoC dtsi file. What you say here is that all MT8135 present and future firmwares on all boards do this wrong. Shouldn't you fix the firmware instead? Shouldn't this property be board specific? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |