linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: EDMA oftree entry for AM335x
Date: Mon, 4 May 2015 14:42:01 -0700	[thread overview]
Message-ID: <20150504214201.GC4810@atomide.com> (raw)
In-Reply-To: <20150504213300.GV15254@pengutronix.de>

* Robert Schwebel <r.schwebel@pengutronix.de> [150504 14:34]:
> On Mon, May 04, 2015 at 02:24:57PM -0700, Tony Lindgren wrote:
> > > I tried this, with the patch below, but it doesn't work:
> > 
> > With the above the tptc instances are being probed as separate
> > device entries that do not register with tpcc without the
> > related driver changes. I don't think we even parse the
> > compatible = "ti,tptc3" property currently.
> 
> How useful is it to let the driver warn about wrong devicetrees then,
> when fixing the devicetrees results in a kernel not supporting it...?

It's there so we can NAK new drivers if somebody tries to sneak
in more stuff like that. Of course it should be fixed for the
existing ones, that's the EDMA and McBSP AFAIK.

> Shouldn't these sort of patches being upstreamed only together with the
> full set of changes?

Ideally these sort of patches never got merged. The right way to fix
this is to first fix the driver, only then do the dts changes.
 
> However, thanks for the infos, I'll stay with the warnings for now.

Yes I figured :)

Regards,

Tony

  reply	other threads:[~2015-05-04 21:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04  6:43 EDMA oftree entry for AM335x Robert Schwebel
2015-05-04 14:11 ` Tony Lindgren
2015-05-04 21:11   ` Robert Schwebel
2015-05-04 21:24     ` Tony Lindgren
2015-05-04 21:33       ` Robert Schwebel
2015-05-04 21:42         ` Tony Lindgren [this message]
2015-05-05 13:53   ` Peter Ujfalusi
2015-05-05 14:58     ` Tony Lindgren
2015-05-06 11:22       ` Peter Ujfalusi
2015-05-06 14:39         ` Tony Lindgren
2015-06-08 10:59           ` Robert Schwebel
2015-06-10  5:10             ` Tony Lindgren
2015-06-10 11:13               ` Peter Ujfalusi
2015-06-11 14:13                 ` Tony Lindgren
2015-06-11 14:53                   ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150504214201.GC4810@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).