From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: Availability of psci_smp_available depends on CONFIG_SMP
Date: Fri, 8 May 2015 17:14:53 +0100 [thread overview]
Message-ID: <20150508161453.GI25587@arm.com> (raw)
In-Reply-To: <20150508145620.GK2067@n2100.arm.linux.org.uk>
On Fri, May 08, 2015 at 03:56:20PM +0100, Russell King - ARM Linux wrote:
> On Fri, May 08, 2015 at 01:26:17PM +0200, Thierry Reding wrote:
> > On Fri, May 08, 2015 at 07:55:26AM +0200, Jan Kiszka wrote:
> > > Ensure that we can use psci_smp_available without checking for
> > > CONFIG_SMP first.
> > >
> > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > > ---
> > > arch/arm/include/asm/psci.h | 6 +++++-
> > > 1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/include/asm/psci.h b/arch/arm/include/asm/psci.h
> > > index c25ef3e..eef6a0a 100644
> > > --- a/arch/arm/include/asm/psci.h
> > > +++ b/arch/arm/include/asm/psci.h
> > > @@ -39,9 +39,13 @@ extern struct smp_operations psci_smp_ops;
> > >
> > > #ifdef CONFIG_ARM_PSCI
> > > int psci_init(void);
> > > -bool psci_smp_available(void);
> > > #else
> > > static inline int psci_init(void) { return 0; }
> > > +#endif
> > > +
> > > +#if defined(CONFIG_ARM_PSCI) && defined(CONFIG_SMP)
> > > +bool psci_smp_available(void);
> > > +#else
> > > static inline bool psci_smp_available(void) { return false; }
> > > #endif
> > >
> >
> > Looks good to me.
> >
> > Russell, would you be willing to ack this patch so that I can take it
> > through the Tegra tree along with patch 2/2 that depends on this?
>
> I'd prefer to see an ack from Will on this, as it's code which Will
> contributed and presumably understands better than me.
Sorry, I'm late to the thread so I'm a tad confused.
If I understand correctly, these two patches are trying to avoid using
the tegra cpuidle driver if PSCI is available instead? That raises the
question as to whether or not you're actually trying to discover whether
you're in the secure or non-secure world.
I assume PSCI only works if the kernel is running in non-secure mode,
but does the Tegra cpuidle driver only work in secure mode?
Will
next prev parent reply other threads:[~2015-05-08 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 5:55 [PATCH 0/2] Make Tegra cpuidle driver PSCI compatible Jan Kiszka
2015-05-08 5:55 ` [PATCH 1/2] ARM: Availability of psci_smp_available depends on CONFIG_SMP Jan Kiszka
2015-05-08 11:26 ` Thierry Reding
2015-05-08 14:56 ` Russell King - ARM Linux
2015-05-08 16:14 ` Will Deacon [this message]
2015-05-10 9:48 ` Jan Kiszka
2015-05-11 12:13 ` Peter De Schrijver
2015-05-08 5:55 ` [PATCH 2/2] ARM: tegra: Disable cpuidle driver if PSCI is present Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150508161453.GI25587@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).