* [PATCH v6 1/1] ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller.
[not found] ` <1431333375-30433-2-git-send-email-stripathi@apm.com>
@ 2015-05-11 11:28 ` Tejun Heo
2015-05-11 13:31 ` Suman Tripathi
0 siblings, 1 reply; 2+ messages in thread
From: Tejun Heo @ 2015-05-11 11:28 UTC (permalink / raw)
To: linux-arm-kernel
Hello, Suman.
On Mon, May 11, 2015 at 02:06:15PM +0530, Suman Tripathi wrote:
> -#ifdef CONFIG_ACPI
> -static const struct acpi_device_id xgene_ahci_acpi_match[] = {
> - { "APMC0D0D", },
> - { }
> -};
> -MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match);
> -#endif
> -
> -static const struct of_device_id xgene_ahci_of_match[] = {
> - {.compatible = "apm,xgene-ahci"},
> - {},
> -};
> -MODULE_DEVICE_TABLE(of, xgene_ahci_of_match);
I applied the patch as-is this time but please don't combine code
movement with actual changes in the future. Split them out to
separate patches. It makes the changes a lot easier to follow and
verify.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v6 1/1] ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller.
2015-05-11 11:28 ` [PATCH v6 1/1] ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller Tejun Heo
@ 2015-05-11 13:31 ` Suman Tripathi
0 siblings, 0 replies; 2+ messages in thread
From: Suman Tripathi @ 2015-05-11 13:31 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tejun,
On Mon, May 11, 2015 at 4:58 PM, Tejun Heo <tj@kernel.org> wrote:
> Hello, Suman.
>
> On Mon, May 11, 2015 at 02:06:15PM +0530, Suman Tripathi wrote:
>> -#ifdef CONFIG_ACPI
>> -static const struct acpi_device_id xgene_ahci_acpi_match[] = {
>> - { "APMC0D0D", },
>> - { }
>> -};
>> -MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match);
>> -#endif
>> -
>> -static const struct of_device_id xgene_ahci_of_match[] = {
>> - {.compatible = "apm,xgene-ahci"},
>> - {},
>> -};
>> -MODULE_DEVICE_TABLE(of, xgene_ahci_of_match);
>
> I applied the patch as-is this time but please don't combine code
> movement with actual changes in the future. Split them out to
> separate patches. It makes the changes a lot easier to follow and
> verify.
Sorry . I will take care of it next time onwards.
>
> Thanks.
>
> --
> tejun
--
Thanks,
with regards,
Suman Tripathi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-11 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1431333375-30433-1-git-send-email-stripathi@apm.com>
[not found] ` <1431333375-30433-2-git-send-email-stripathi@apm.com>
2015-05-11 11:28 ` [PATCH v6 1/1] ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller Tejun Heo
2015-05-11 13:31 ` Suman Tripathi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).