From mboxrd@z Thu Jan 1 00:00:00 1970 From: mwelling@ieee.org (Michael Welling) Date: Mon, 11 May 2015 15:16:33 -0500 Subject: next-20150511 / omap2-mcspi: regression for sdp4430 boot In-Reply-To: <5550FC38.6020801@ti.com> References: <5550DDCB.8010303@ti.com> <20150511170742.GA6616@deathray> <5550F47C.1030902@ti.com> <20150511183032.GA8085@deathray> <5550FC38.6020801@ti.com> Message-ID: <20150511201633.GA31117@deathray> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, May 11, 2015 at 02:00:08PM -0500, Nishanth Menon wrote: > On 05/11/2015 01:30 PM, Michael Welling wrote: > > On Mon, May 11, 2015 at 01:27:08PM -0500, Nishanth Menon wrote: > >> On 05/11/2015 12:07 PM, Michael Welling wrote: > >>> On Mon, May 11, 2015 at 11:50:19AM -0500, Nishanth Menon wrote: > >>>> Hi, > >>>> > >>>> SDP4430 uses a SPI based network chip ks8851. > >>>> > >>>> next-20150508: > >>>> https://github.com/nmenon/kernel-test-logs/blob/next-20150508/omap2plus_defconfig/sdp4430.txt > >>>> > >>>> However, next-20150511: > >>>> https://github.com/nmenon/kernel-test-logs/blob/next-20150511/omap2plus_defconfig/sdp4430.txt > >>>> > >>> > >>> I will look into this but it is going to be difficult to debug with access to the hardware. > >>> This is what I get for changing a driver that effects so many SoCs. > >>> > >> > >> Let me know if there is any test patch you'd want me to run. The board > >> is on a remote "board farm" which most of TI folks have access to as > >> well.. So, if you need anything run, just send out a debug patch OR a > >> potential fix and we can help try it out and provide logs back for > >> your debug. > > > > Okay. > > > > It looks like you revert the patches in the wrong order above. > > > > The GPIO patch should apply after the transfer_one patch so it should > > logically be reverted in the reverse order. > > > Apologies on a slow response, was tracking another LPAE regression down. > > I did do that -> but logged it in reverse - unfortunately it seems to > have caused a little more confusion :(. is there something else you'd > like me to do? Okay I have another patch that appears to fix the issue on my board. Please test the attached patch and see if it fixes the issue on your board. If it does, I will send it upstream. > > git log next-20150508..next-20150511 drivers/spi > Tells me: > > commit bc7f9bbc80bcc77745b3f54ec4e7103e3e142bb9 > Author: Michael Welling > Date: Fri May 8 13:31:01 2015 -0500 > > spi: omap2-mcspi: Add gpio_request and init CS > > If GPIO chip select is specified, request the GPIO in the setup > function > and release it in the cleanup function. > > Signed-off-by: Michael Welling > Signed-off-by: Mark Brown > > commit b28cb9414db9f8e42ac18c9e360e4e99cda42489 > Author: Michael Welling > Date: Thu May 7 18:36:53 2015 -0500 > > spi: omap2-mcspi: Switch driver to use transfer_one > > Switches from transfer_one_message to transfer_one to prepare > driver for > use of GPIO chip selects. > > Signed-off-by: Michael Welling > Signed-off-by: Mark Brown > > > > my tested git log looks as follows: (redid it just to be sure): > > a4617b41e04c Revert "spi: omap2-mcspi: Switch driver to use transfer_one" > http://paste.ubuntu.org.cn/2595136 > > b49011271c7f Revert "spi: omap2-mcspi: Add gpio_request and init CS" > http://paste.ubuntu.org.cn/2595142 > > > 012034602bd6 HACK: Makefile: Build a uImage with dtb already appended > f17107cb8886 Add linux-next specific files for 20150511 > > 012034602bd6 commit is > https://github.com/nmenon/linux-2.6-playground/commit/177f5f71b3f2 -> > for legacy platforms needing uImage based booting. > > -- > Regards, > Nishanth Menon -------------- next part -------------- A non-text attachment was scrubbed... Name: omap-mcspi.patch Type: text/x-diff Size: 2909 bytes Desc: not available URL: