linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM64: kernel: make cpu_ops hooks DT agnostic
Date: Tue, 12 May 2015 11:45:29 +0100	[thread overview]
Message-ID: <20150512104529.GC16079@red-moon> (raw)
In-Reply-To: <20150511160401.GC4595@leverpostej>

On Mon, May 11, 2015 at 05:04:02PM +0100, Mark Rutland wrote:
> Hi Lorenzo,
> 
> >  /**
> >   * struct cpu_operations - Callback operations for hotplugging CPUs.
> >   *
> > - * @name:	Name of the property as appears in a devicetree cpu node's
> > - *		enable-method property.
> > - * @cpu_init:	Reads any data necessary for a specific enable-method from the
> > - *		devicetree, for a given cpu node and proposed logical id.
> > + * @name:	Name of the enable-method.
> 
> I'm not keen on dropping the DT portion from the name documentation,
> given the name must be the DT enable-method string. I'd prefer to leave
> the original comment, or something at least mentioning that the name is
> a DT enable-method string.

Ok, I will reword the comment so that that string makes sense in ACPI
too, leaving DT wording unchanged.

> Other than that, this patch looks fine to me, and I don't see issues
> booting on a (DT) system, so:
> 
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Tested-by: Mark Rutland <mark.rutland@arm.com> [DT]
> 
> Has this has been tested on an ACPI system?

Yes I tested ACPI SMP boot on Juno with it applied.

Thank you !
Lorenzo

  parent reply	other threads:[~2015-05-12 10:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07 17:34 [PATCH 1/2] ARM64: kernel: make cpu_ops hooks DT agnostic Lorenzo Pieralisi
2015-05-07 17:34 ` [PATCH 2/2] ARM64: kernel: unify ACPI and DT cpus initialization Lorenzo Pieralisi
2015-05-11 16:29   ` Mark Rutland
2015-05-12 10:37     ` Lorenzo Pieralisi
2015-05-11 16:04 ` [PATCH 1/2] ARM64: kernel: make cpu_ops hooks DT agnostic Mark Rutland
2015-05-12  1:31   ` Hanjun Guo
2015-05-12 10:45   ` Lorenzo Pieralisi [this message]
2015-05-12 13:43 ` Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512104529.GC16079@red-moon \
    --to=lorenzo.pieralisi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).