public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: mturquette@linaro.org (Michael Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] clk: add lpc18xx ccu clk driver
Date: Tue, 12 May 2015 15:32:41 -0700	[thread overview]
Message-ID: <20150512223241.16410.79958@quantum> (raw)
In-Reply-To: <1430170693-28303-4-git-send-email-manabian@gmail.com>

Quoting Joachim Eastwood (2015-04-27 14:38:12)
> +static int of_clk_get_parent_arg(struct device_node *np, int index)
> +{
> +       struct of_phandle_args clkspec;
> +       int rc;
> +
> +       if (index < 0)
> +               return -EINVAL;
> +
> +       rc = of_parse_phandle_with_args(np, "clocks", "#clock-cells", index,
> +                                       &clkspec);
> +       if (rc)
> +               return -EINVAL;
> +
> +       return clkspec.args_count ? clkspec.args[0] : -EINVAL;
> +}

Hi Joachim,

I'm not sure why you need this. I guess it is related to my question in
patch #2 about using clock-indices? Can you explain why this function is
required?

Anyways if returning the clock index is something that is really needed
then why not rename it to "of_clk_get_index" and put it in
drivers/clk/clk.c?

Thanks,
Mike

  reply	other threads:[~2015-05-12 22:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 21:38 [PATCH v2 0/4] Clk drivers for NXP LPC18xx family Joachim Eastwood
2015-04-27 21:38 ` [PATCH v2 1/4] clk: add lpc18xx cgu clk driver Joachim Eastwood
2015-04-27 21:38 ` [PATCH v2 2/4] doc: dt: add documentation for lpc1850-cgu " Joachim Eastwood
2015-05-12 22:12   ` Michael Turquette
2015-05-13  7:57     ` Joachim Eastwood
2015-05-21 21:17       ` Michael Turquette
2015-05-21 22:21         ` Joachim Eastwood
2015-04-27 21:38 ` [PATCH v2 3/4] clk: add lpc18xx ccu " Joachim Eastwood
2015-05-12 22:32   ` Michael Turquette [this message]
2015-05-13  8:09     ` Joachim Eastwood
2015-04-27 21:38 ` [PATCH v2 4/4] doc: dt: add documentation for lpc1850-ccu " Joachim Eastwood
2015-05-12 22:31 ` [PATCH v2 0/4] Clk drivers for NXP LPC18xx family Stephen Boyd
2015-05-13  6:56   ` Joachim Eastwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512223241.16410.79958@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox