From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] mtd: mxc_nand: fix truncate of unaligned oob copying
Date: Wed, 13 May 2015 09:59:22 +0300 [thread overview]
Message-ID: <20150513065922.GN2558@tarshish> (raw)
In-Reply-To: <20150513064734.GF28888@pengutronix.de>
Hi Uwe,
On Wed, May 13, 2015 at 08:47:34AM +0200, Uwe Kleine-K?nig wrote:
> On Wed, May 13, 2015 at 09:44:04AM +0300, Baruch Siach wrote:
> > > I thought we could get rid of the memcpy32 variants. Where do we need
> > > memcpy32_* where memcpy16 wouldn't work?
> >
> > memcpy16 should work, but would take twice as much IO/memory accesses. That
> > would definitely affect performance, as this is the flash data read/write hot
> > path. I didn't test, though.
> >
> > Are you sure we want to do that?
> no, I'm not sure. But I think it's worth to test how much performance
> degrades.
That will have to wait a few weeks as I don't have the hardware handy at the
moment.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-05-13 6:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 7:18 [PATCH v2 0/4] mtd: mxc_nand: fix 8 bit ECC and large oob Baruch Siach
2015-05-03 7:18 ` [PATCH v2 1/4] mtd: nand: mxc_nand: cleanup copy_spare function Baruch Siach
2015-05-03 7:18 ` [PATCH v2 2/4] mtd: mxc_nand: limit the size of used oob Baruch Siach
2015-05-03 7:18 ` [PATCH v2 3/4] mtd: mxc_nand: fix truncate of unaligned oob copying Baruch Siach
2015-05-08 7:24 ` Uwe Kleine-König
2015-05-13 5:12 ` Baruch Siach
2015-05-13 6:39 ` Uwe Kleine-König
2015-05-13 6:44 ` Baruch Siach
2015-05-13 6:47 ` Uwe Kleine-König
2015-05-13 6:59 ` Baruch Siach [this message]
2015-05-13 7:01 ` Uwe Kleine-König
2015-05-13 7:12 ` Baruch Siach
2015-05-13 7:18 ` Uwe Kleine-König
2015-05-03 7:18 ` [PATCH v2 4/4] mtd: mxc_nand: generate nand_ecclayout for 8 bit ECC Baruch Siach
2015-05-08 7:21 ` Uwe Kleine-König
2015-05-08 5:15 ` [PATCH v2 0/4] mtd: mxc_nand: fix 8 bit ECC and large oob Sascha Hauer
2015-05-13 5:22 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513065922.GN2558@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox