* [patch] ARM: pxa: pxa_cplds: signedness bug in probe
@ 2015-05-13 11:32 Dan Carpenter
2015-05-13 19:52 ` Robert Jarzmik
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-05-13 11:32 UTC (permalink / raw)
To: linux-arm-kernel
"base_irq" needs to be signed for the error handling to work. Also we
can remove the initialization because we re-assign it later.
Fixes: aa8d6b73ea33 ('ARM: pxa: pxa_cplds: add lubbock and mainstone IO')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/arch/arm/mach-pxa/pxa_cplds_irqs.c b/arch/arm/mach-pxa/pxa_cplds_irqs.c
index f1aeb54..2385052 100644
--- a/arch/arm/mach-pxa/pxa_cplds_irqs.c
+++ b/arch/arm/mach-pxa/pxa_cplds_irqs.c
@@ -107,7 +107,7 @@ static int cplds_probe(struct platform_device *pdev)
struct resource *res;
struct cplds *fpga;
int ret;
- unsigned int base_irq = 0;
+ int base_irq;
unsigned long irqflags = 0;
fpga = devm_kzalloc(&pdev->dev, sizeof(*fpga), GFP_KERNEL);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [patch] ARM: pxa: pxa_cplds: signedness bug in probe
2015-05-13 11:32 [patch] ARM: pxa: pxa_cplds: signedness bug in probe Dan Carpenter
@ 2015-05-13 19:52 ` Robert Jarzmik
0 siblings, 0 replies; 2+ messages in thread
From: Robert Jarzmik @ 2015-05-13 19:52 UTC (permalink / raw)
To: linux-arm-kernel
Dan Carpenter <dan.carpenter@oracle.com> writes:
> "base_irq" needs to be signed for the error handling to work. Also we
> can remove the initialization because we re-assign it later.
Indeed.
I suppose smatch found this one with :
arch/arm/mach-pxa/pxa_cplds_irqs.c:126 cplds_probe() warn: unsigned
'base_irq' is never less than zero.
I still don't see which tool found the "re-assign" part ...
Anyway, thanks for this, I'll queue it in pxa/fixes.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-13 19:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-13 11:32 [patch] ARM: pxa: pxa_cplds: signedness bug in probe Dan Carpenter
2015-05-13 19:52 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).